[SOLVED] Cleanup old users with no ads and not logged in for xxx period

[Aficionado]

Actually just now i realized that is a bug of Osclass.

Easy to replicate:

Mark FIRST a post as SPAM and then delete it. The count of the user items doesn't change.

[teseo]

When you mark an ad as spam, the total count decreases already, so no difference later when you delete it.

Regards

[Aficionado]

hm .....

[Aficionado]

yeap.

This is the code from some spam plugin, marks as spam but doesn't update the count i guess.

Code: [Select]

function after_item_posted($item) {
if( getEnableOn() == 1 || getEnableOn() == 2 ){
  $arrstopword= getStopWords();
  $exparrstopword= explode(",", $arrstopword);
  foreach ($exparrstopword as $expstopword) {
    if (preg_match("/" . $expstopword. "/i", $item['s_title']) || preg_match("/" . $expstopword. "/i", $item['s_description'])) {
ModelSpamKiller::newInstance()->blockItem($item['pk_i_id']);
}
  }
  }
}

and

Code: [Select]


function blockItem($id){
            $this->dao->from($this->getItemTable()) ;
            $this->dao->set(array(
                'b_spam' => 1
            )) ;
            $this->dao->where(array(
                'pk_i_id' => $id
            )) ;
$this->dao->update() ;
        }

[teseo]

That's why vanilla methods should be used if they exist, they are supposed to take care of everything:

Code: [Select]

if (preg_match("/" . $expstopword. "/i", $item['s_title']) || preg_match("/" . $expstopword. "/i", $item['s_description'])) {
// ModelSpamKiller::newInstance()->blockItem();
            $action = new ItemActions();
            $action->spam($item['pk_i_id']);
}
Regards