Osclass forums
Support forums => old => Topic started by: destabilizator on August 24, 2015, 04:44:10 pm
-
I have a custom field for listings and set "Tick to allow searches by this field". When I just click "Search" (no search string or category specified), it lists all listings. But I don't see my custom field in the search-sidebar.
If I refine the category (from here or search empty string with some category selected), it shows my custom field in search-sidebar.
Any hint to fix this? So basically user can filter "all listings in all categories" by my custom field.
-
@destabilizator
- every custom fields needs to be assigned to some categories
- that means custom field is dependand on category
- if no category is selected in search, no custom field is shown as all custom fields are category related
- if you select category, all CFs related to this category are shown
- even if you attach CF to all categories, still it is required to have some category selected
Therefore, no bug there, but it would be nice to have checkbox there "Use globally, not category related"
-
***CORRECTED AGAIN***
Hi,
Here's a way to achieve that:
Add this at the very bottom of your theme functions.php:
Notes:
1.- Take care not to leave blank lines after this.
2.- If your theme functions.php doesn't end with ?> skip first line of my code.
<?php
function cust_global_custom_field_form() {
if(!osc_search_category_id()) {
$global_custom_fields = array('dropdown-1', 'other-dropdown'); // Put here one or more custom fields slugs
$nField = new Field();
foreach ($global_custom_fields AS $slug) {
$global_custom_field = $nField->findBySlug($slug);
FieldForm::meta($global_custom_field, true);
echo "<p></p>";
}
}
}
osc_add_hook('search_form', 'cust_global_custom_field_form');
function cust_global_custom_field_search_conditions($params) {
if (@$params['meta'] && !@$params['sCategory']) {
$metas = $params['meta'];
$mSearch = Search::newInstance();
$table = DB_TABLE_PREFIX.'t_item_meta';
foreach ($metas as $key => $aux) {
$cField = new Field();
$field = $cField->findByPrimaryKey($key);
switch ($field['e_type']) {
case 'TEXTAREA':
case 'TEXT':
case 'URL':
if($aux!='') {
$aux = "%$aux%";
$sql = "SELECT fk_i_item_id FROM $table WHERE ";
$str_escaped = $mSearch->dao->escape($aux);
$sql .= $table.'.fk_i_field_id = '.$key.' AND ';
$sql .= $table.".s_value LIKE ".$str_escaped;
$mSearch->addConditions(DB_TABLE_PREFIX.'t_item.pk_i_id IN ('.$sql.')');
}
break;
case 'DROPDOWN':
case 'RADIO':
if($aux!='') {
$sql = "SELECT fk_i_item_id FROM $table WHERE ";
$str_escaped = $mSearch->dao->escape($aux);
$sql .= $table.'.fk_i_field_id = '.$key.' AND ';
$sql .= $table.".s_value = ".$str_escaped;
$mSearch->addConditions(DB_TABLE_PREFIX.'t_item.pk_i_id IN ('.$sql.')');
}
break;
case 'CHECKBOX':
if($aux!='') {
$sql = "SELECT fk_i_item_id FROM $table WHERE ";
$sql .= $table.'.fk_i_field_id = '.$key.' AND ';
$sql .= $table.".s_value = 1";
$mSearch->addConditions(DB_TABLE_PREFIX.'t_item.pk_i_id IN ('.$sql.')');
}
break;
case 'DATE':
if($aux!='') {
$y = (int)date('Y', $aux);
$m = (int)date('n', $aux);
$d = (int)date('j', $aux);
$start = mktime('0', '0', '0', $m, $d, $y);
$end = mktime('23', '59', '59', $m, $d, $y);
$sql = "SELECT fk_i_item_id FROM $table WHERE ";
$sql .= $table.'.fk_i_field_id = '.$key.' AND ';
$sql .= $table.".s_value >= ".($start)." AND ";
$sql .= $table.".s_value <= ".$end;
$mSearch->addConditions(DB_TABLE_PREFIX.'t_item.pk_i_id IN ('.$sql.')');
}
break;
case 'DATEINTERVAL':
if( is_array($aux) && (!empty($aux['from']) && !empty($aux['to'])) ) {
$from = $aux['from'];
$to = $aux['to'];
$start = $from;
$end = $to;
$sql = "SELECT fk_i_item_id FROM $table WHERE ";
$sql .= $table.'.fk_i_field_id = '.$key.' AND ';
$sql .= $start." >= ".$table.".s_value AND s_multi = 'from'";
$sql1 = "SELECT fk_i_item_id FROM $table WHERE ";
$sql1 .= $table.".fk_i_field_id = ".$key." AND ";
$sql1 .= $end." <= ".$table.".s_value AND s_multi = 'to'";
$sql_interval = "select a.fk_i_item_id from (".$sql.") a where a.fk_i_item_id IN (".$sql1.")";
$mSearch->addConditions(DB_TABLE_PREFIX.'t_item.pk_i_id IN ('.$sql_interval.')');
}
break;
default:
break;
}
}
}
}
osc_add_hook('search_conditions', 'cust_global_custom_field_search_conditions');
?>
You need to manually set one or several "global" custom fields using their slug (Identifier name) to identify them:
$global_custom_fields = array('dropdown-1', 'other-dropdown'); // Put here one or more custom fields slugs
Regards
-
Thanks Teseo, this works on the first try! :)
On a related note, I'm using http://plugins-zone.com/free-plugins-for-osclass/tags-plugin.html and I'd like following to happen:
- User enters eg. "blabla hehe" in the main-search field
- apart from normal search, I'll take the user's input, split it to "blabla" and "hehe" words
- I'd like to search for "blabla" and "hehe" also in tags, so the output of the search is every listing where "blabla hehe" is written + those which have "blabla" and "hehe" as tags
Bonus tought: would it be hard to modify even the normal search so it does search for "blabla hehe" "blabla" "hehe"?
-
You're welcome. :) Please add [SOLVED] to the title of this thread.
Regarding your new question, please open a new thread. I don't know that plugin but I'd take a look at it.
Regards
-
Hi,
Detected a bug in the code, it wasn't working properly when using several custom fields. Corrected in the post above.
Regards
-
Not sure why but this does not work for me. When I paste it to the end of functions.php in my theme folder, the entire website gives me an error 500. Can not even access admin panel afterwards.
-
Look for space or new line after you passed the code into functions. It must be a typo.
Notes:
1.- Take care not to leave blank lines after this.
2.- If your theme functions.php doesn't end with ?> skip first line of my code.
For me it workes great. Thank you Teseo.
-
Teseo, I get
PHP Notice: Undefined index: sCategory in /oc-content/themes/bender/functions.php on line 880 // when I select one custom field
PHP Notice: Undefined index: meta in /oc-content/themes/bender/functions.php on line 880 // when I don't select a custom field
for
if ($params['meta'] && !$params['sCategory']) {
This time when I use the search.
The only case when a notice does not apear is when a category is selected and the global custom field is selected.
SOLVED with
if (isset($params['meta']) && !isset($params['sCategory'])) {
-
Thanks marius.
This will be enough:
if (@$params['meta'] && !@$params['sCategory']) {
Regards
-
Oh yeah... I forgot about the @ :)) anyway. It works fine. Thanks again.
-
Will this work with the custom attributes plugin? I am unsure how to find the slug id of attributes added with the plugin. Also im using the osclass wizard plugin if that makes a difference. Any help would be great.
-
Hi,
No, a completely different mechanism.
Regards
-
Teseo. Is this method taking care of the posible sql injection in case the custom field is text type?
At first look it isn't....
Edit And even if it's of other type, with F12 in browser the values could be altered.
-
Hi,
You're right (although I couldn't see any way to introduce here something really harmful). I've corrected the code, now all the values are escaped following the Osclass standard mechanism.
Regards
-
Thank you.
-
Something is not ok. It;s not displaying the custom field when no category is selected
Sorry I forgot to edit the code:))
Workes ok. Thanks.
-
Hi Teseo.
Were is this function located?
$mSearch->dao->escape($aux);
I found only
oc-includes/htmlpurifier/HTMLPurifier/Generator.php: public function escape($string, $quote = null) {
oc-includes/htmlpurifier/HTMLPurifier/Printer.php: protected function escape($string) {
oc-includes/osclass/classes/database/DBCommandClass.php: function escape($str)
and in these files there is no "dao" class extended.
Thank you.
-
It's in DBCommandClass.php
Variable "dao" is assigned in DAO.php as an instance of DBCommandClass class:
$this->dao = new DBCommandClass($data);
Regards
-
Thank you. I wanted to be shure that I use it ok like this:
oc-includes/osclass/controller/search.php
$from = $aux['from'];
$to = $aux['to'];
$start = Search::newInstance()->dao->escape($from);
$end = Search::newInstance()->dao->escape($to);In my other thread about the NUMERIC custom field.
EDIT. and if someone uses this solution from you https://forums.osclass.org/3-5-x/custom-field-search-when-'all-categories'/msg128243/#msg128243
toghether with this new type of custom field https://forums.osclass.org/development/new-type-of-custom-field-suggestion-number-input-and-interval-filter/msg159215/#msg159215
Then your solution should be
instead of
***CORRECTED AGAIN***
Hi,
Here's a way to achieve that:
Add this at the very bottom of your theme functions.php:
Notes:
1.- Take care not to leave blank lines after this.
2.- If your theme functions.php doesn't end with ?> skip first line of my code.
<?php
function cust_global_custom_field_form() {
if(!osc_search_category_id()) {
$global_custom_fields = array('dropdown-1', 'other-dropdown'); // Put here one or more custom fields slugs
$nField = new Field();
foreach ($global_custom_fields AS $slug) {
$global_custom_field = $nField->findBySlug($slug);
FieldForm::meta($global_custom_field, true);
echo "<p></p>";
}
}
}
osc_add_hook('search_form', 'cust_global_custom_field_form');
function cust_global_custom_field_search_conditions($params) {
if (@$params['meta'] && !@$params['sCategory']) {
$metas = $params['meta'];
$mSearch = Search::newInstance();
$table = DB_TABLE_PREFIX.'t_item_meta';
foreach ($metas as $key => $aux) {
$cField = new Field();
$field = $cField->findByPrimaryKey($key);
switch ($field['e_type']) {
case 'TEXTAREA':
case 'TEXT':
case 'URL':
if($aux!='') {
$aux = "%$aux%";
$sql = "SELECT fk_i_item_id FROM $table WHERE ";
$str_escaped = $mSearch->dao->escape($aux);
$sql .= $table.'.fk_i_field_id = '.$key.' AND ';
$sql .= $table.".s_value LIKE ".$str_escaped;
$mSearch->addConditions(DB_TABLE_PREFIX.'t_item.pk_i_id IN ('.$sql.')');
}
break;
case 'DROPDOWN':
case 'RADIO':
if($aux!='') {
$sql = "SELECT fk_i_item_id FROM $table WHERE ";
$str_escaped = $mSearch->dao->escape($aux);
$sql .= $table.'.fk_i_field_id = '.$key.' AND ';
$sql .= $table.".s_value = ".$str_escaped;
$mSearch->addConditions(DB_TABLE_PREFIX.'t_item.pk_i_id IN ('.$sql.')');
}
break;
case 'CHECKBOX':
if($aux!='') {
$sql = "SELECT fk_i_item_id FROM $table WHERE ";
$sql .= $table.'.fk_i_field_id = '.$key.' AND ';
$sql .= $table.".s_value = 1";
$mSearch->addConditions(DB_TABLE_PREFIX.'t_item.pk_i_id IN ('.$sql.')');
}
break;
case 'DATE':
if($aux!='') {
$y = (int)date('Y', $aux);
$m = (int)date('n', $aux);
$d = (int)date('j', $aux);
$start = mktime('0', '0', '0', $m, $d, $y);
$end = mktime('23', '59', '59', $m, $d, $y);
$sql = "SELECT fk_i_item_id FROM $table WHERE ";
$sql .= $table.'.fk_i_field_id = '.$key.' AND ';
$sql .= $table.".s_value >= ".($start)." AND ";
$sql .= $table.".s_value <= ".$end;
$mSearch->addConditions(DB_TABLE_PREFIX.'t_item.pk_i_id IN ('.$sql.')');
}
break;
case 'DATEINTERVAL':
if( is_array($aux) && (!empty($aux['from']) && !empty($aux['to'])) ) {
$from = $aux['from'];
$to = $aux['to'];
$start = $from;
$end = $to;
$sql = "SELECT fk_i_item_id FROM $table WHERE ";
$sql .= $table.'.fk_i_field_id = '.$key.' AND ';
$sql .= $start." >= ".$table.".s_value AND s_multi = 'from'";
$sql1 = "SELECT fk_i_item_id FROM $table WHERE ";
$sql1 .= $table.".fk_i_field_id = ".$key." AND ";
$sql1 .= $end." <= ".$table.".s_value AND s_multi = 'to'";
$sql_interval = "select a.fk_i_item_id from (".$sql.") a where a.fk_i_item_id IN (".$sql1.")";
$mSearch->addConditions(DB_TABLE_PREFIX.'t_item.pk_i_id IN ('.$sql_interval.')');
}
break;
default:
break;
}
}
}
}
osc_add_hook('search_conditions', 'cust_global_custom_field_search_conditions');
?>
You need to manually set one or several "global" custom fields using their slug (Identifier name) to identify them:
$global_custom_fields = array('dropdown-1', 'other-dropdown'); // Put here one or more custom fields slugs
Regards
EDITED
<?php
function cust_global_custom_field_form() {
if(!osc_search_category_id()) {
$global_custom_fields = array('dropdown-1', 'other-dropdown'); // Put here one or more custom fields slugs
$nField = new Field();
foreach ($global_custom_fields AS $slug) {
$global_custom_field = $nField->findBySlug($slug);
FieldForm::meta($global_custom_field, true);
echo "<p></p>";
}
}
}
osc_add_hook('search_form', 'cust_global_custom_field_form');
function cust_global_custom_field_search_conditions($params) {
if (@$params['meta'] && !@$params['sCategory']) {
$metas = $params['meta'];
$mSearch = Search::newInstance();
$table = DB_TABLE_PREFIX.'t_item_meta';
foreach ($metas as $key => $aux) {
$cField = new Field();
$field = $cField->findByPrimaryKey($key);
switch ($field['e_type']) {
case 'TEXTAREA':
case 'TEXT':
case 'URL':
if($aux!='') {
$aux = "%$aux%";
$sql = "SELECT fk_i_item_id FROM $table WHERE ";
$str_escaped = $mSearch->dao->escape($aux);
$sql .= $table.'.fk_i_field_id = '.$key.' AND ';
$sql .= $table.".s_value LIKE ".$str_escaped;
$mSearch->addConditions(DB_TABLE_PREFIX.'t_item.pk_i_id IN ('.$sql.')');
}
break;
case 'DROPDOWN':
case 'RADIO':
if($aux!='') {
$sql = "SELECT fk_i_item_id FROM $table WHERE ";
$str_escaped = $mSearch->dao->escape($aux);
$sql .= $table.'.fk_i_field_id = '.$key.' AND ';
$sql .= $table.".s_value = ".$str_escaped;
$mSearch->addConditions(DB_TABLE_PREFIX.'t_item.pk_i_id IN ('.$sql.')');
}
break;
case 'CHECKBOX':
if($aux!='') {
$sql = "SELECT fk_i_item_id FROM $table WHERE ";
$sql .= $table.'.fk_i_field_id = '.$key.' AND ';
$sql .= $table.".s_value = 1";
$mSearch->addConditions(DB_TABLE_PREFIX.'t_item.pk_i_id IN ('.$sql.')');
}
break;
case 'DATE':
if($aux!='') {
$y = (int)date('Y', $aux);
$m = (int)date('n', $aux);
$d = (int)date('j', $aux);
$start = mktime('0', '0', '0', $m, $d, $y);
$end = mktime('23', '59', '59', $m, $d, $y);
$sql = "SELECT fk_i_item_id FROM $table WHERE ";
$sql .= $table.'.fk_i_field_id = '.$key.' AND ';
$sql .= $table.".s_value >= ".($start)." AND ";
$sql .= $table.".s_value <= ".$end;
$mSearch->addConditions(DB_TABLE_PREFIX.'t_item.pk_i_id IN ('.$sql.')');
}
break;
case 'DATEINTERVAL':
if( is_array($aux)) {
if(!empty($aux['to']) && empty($aux['from'])) $aux['from'] = '0';
if(!empty($aux['from']) && empty($aux['to'])) $aux['to'] = '253202544000';
$from = $aux['from'];
$to = $aux['to'];
$end = $to;
$sql = "SELECT fk_i_item_id FROM $table WHERE ";
$sql .= $table.'.fk_i_field_id = '.$key.' AND ';
$sql .= $start." >= ".$table.".s_value AND s_multi = 'from'";
$sql1 = "SELECT fk_i_item_id FROM $table WHERE ";
$sql1 .= $table.".fk_i_field_id = ".$key." AND ";
$sql1 .= $end." <= ".$table.".s_value AND s_multi = 'to'";
$sql_interval = "select a.fk_i_item_id from (".$sql.") a where a.fk_i_item_id IN (".$sql1.")";
$mSearch->addConditions(DB_TABLE_PREFIX.'t_item.pk_i_id IN ('.$sql_interval.')');
}
break;
case 'NUMERIC':
if( is_array($aux)) {
if(!empty($aux['to']) && empty($aux['from'])) $aux['from'] = '-1000000';
if(!empty($aux['from']) && empty($aux['to'])) $aux['to'] = '10000000';
$from = $aux['from'];
$to = $aux['to'];
$start = Search::newInstance()->dao->escape($from);
$end = Search::newInstance()->dao->escape($to);
$sql = "SELECT fk_i_item_id FROM $table WHERE ";
$sql .= $table.'.fk_i_field_id = '.$key.' AND CAST(';
$sql .= $start." AS SIGNED) <= CAST(".$table.".s_value AS SIGNED) AND CAST(".$end." AS SIGNED) >= CAST(".$table.".s_value AS SIGNED)";
$mSearch->addConditions(DB_TABLE_PREFIX.'t_item.pk_i_id IN ('.$sql.')');
}
break;
default:
break;
}
}
}
}
osc_add_hook('search_conditions', 'cust_global_custom_field_search_conditions');
?>
Please confirm
-
.