Advertisement:

Author Topic: No fancybox for images???  (Read 3240 times)

zombie

  • Sr. Member
  • ****
  • Posts: 376
No fancybox for images???
« on: March 03, 2013, 12:40:59 am »
Why? There is no fancybox for images on osclass 3.1?? When the visitor clicks on the image on a listings it opens the image url in the same window :( How can I fix this on 3.1? I can see there is fancybox script in the page source. I can see it's files when i browse the template folder. I use modern theme on osclass 3.1 for a site and it won't work.
« Last Edit: March 03, 2013, 12:52:59 am by zombie »

zombie

  • Sr. Member
  • ****
  • Posts: 376
Re: No fancybox for images???
« Reply #1 on: March 03, 2013, 01:23:27 am »
There were lots of other errors, too!
User can't edit their images to ads, admin can't regenerate images, etc.
I uploaded the 3.02 files instead. Everything works now...

mmcsus

  • Hero Member
  • *****
  • Posts: 704
  • Open Source
Re: No fancybox for images???
« Reply #2 on: March 03, 2013, 01:35:03 am »
@zombie

 Until the problem is solved you can paste the following in the "head" of your /theme/item.php


Code: [Select]
<script type="text/javascript" src="<?php echo osc_current_web_theme_js_url('fancybox/jquery.fancybox.js') ; ?>"></script>
        <link href="<?php echo osc_current_web_theme_js_url('fancybox/jquery.fancybox.css') ; ?>" rel="stylesheet" type="text/css" />
« Last Edit: March 03, 2013, 01:52:18 am by mmcsus »

zombie

  • Sr. Member
  • ****
  • Posts: 376
Re: No fancybox for images???
« Reply #3 on: March 03, 2013, 01:36:12 am »
David, there were too many problems to switch to 3.1 for now. Thanks. Hope they get them fixed.

kcguy

  • Full Member
  • ***
  • Posts: 103
Re: No fancybox for images???
« Reply #4 on: March 03, 2013, 08:49:39 am »
David, there were too many problems to switch to 3.1 for now. Thanks. Hope they get them fixed.

+1

You would have thought they would have did a good testing period before release.... I am not knocking osclass as I really like the whole system but a release all all the errors... come on arrrrggggg....

_CONEJO

  • Administrator
  • Hero Member
  • *****
  • Posts: 4689
Re: No fancybox for images???
« Reply #5 on: March 04, 2013, 02:45:43 pm »
Here's the fix for it : https://github.com/osclass/Osclass/commit/cd9f75080f42d681be2e6bce709269073c0bcec2


We DID test it, in fact, osclass has passed all our tests (automated tests) which I could assure you tests a lot of things (but of course, not all).

The problem is that our tests are done in the "testing server" which has ONE and only one configuration, one version of PHP, one of MySQL,... so if your version of PHP is different, or your configuration or... then, there's a possibility there's an error on your machine but not on ours. For example, we tested the update functionality in 4 different machines (2 linux, 2macs) and we did not detect it (it didn't happen to us), also, no-one complained about it on the RC version (previous to the stable release). But this is no excuse, the fancybox error appeared also on my setup, so I should had seen it.

A hotfix version is going to be released soon. Thanks for all your support