Osclass forums
Support forums => General help => 3.7.x => Topic started by: frosticek on December 20, 2016, 08:33:32 pm
-
On 3.7, when I use following URL:
http://my_site.com/index.php?page=item&action=send_friend&id=112&content_type=add_comment
Then parameter ID is taken as "112&content_type=add_comment" and not just "112"
Parameter CONTENT_TYPE is not possible to get.
So it is not possible to custom parameters in URLs.
On 3.6.3, everything works fine.
-
Hi Frosti,
you meant 3.6.1 or was there a 3.6.3 I missed?
(Nice catch b.t.w.)
Regards,
Eric
-
Hi Michael,
there was a necessary change in parameters to fix some old bugs, but it is possible this introduced the bug you've noticed.
Here's the issue:
https://github.com/osclass/Osclass/issues/2092
Regards
-
For me it is pretty critical. In my themes I customize files with different parameters so it is not functional now...
-
We can not reproduce this issue, could you tell us something more about your setup?
-
parameter parsing is done in php. are you sure you are using the ampersand '&' and not '&' which is html encoded ampersand
-
I am going to reinstall my dev installation, it behave little weird in last weeks and maybe upgrade did not helped.
-
There could be 1 major bug with 3.7 upgrade.
It tells php 5.6 or higher is required, however I had osclass 3.6.3 with php 5.3 and it allowed me to upgrade into 3.7...
-
@_CONEJO
fixed by changing name of parameter content_type.... using this name it stopped to work.
-
Requirement is only for new installations.
-
There could be 1 major bug with 3.7 upgrade.
It tells php 5.6 or higher is required, however I had osclass 3.6.3 with php 5.3 and it allowed me to upgrade into 3.7...
As dev101 said, requirement is for new installation. It should work fine with PHP 5.3 (and even previous versions), but you should think and upgrade your PHP version. PHP 5.3 is "dead" since August 2014. https://en.wikipedia.org/wiki/PHP#Release_history But we could not/should not support old versions of PHP, too many problems with compatibility.
The performance improvement from changing to PHP 7.0 (or higher) is huge
-
Please try this fix : https://github.com/osclass/Osclass/commit/ecfe72932f2467097473f854a0812358ae21afc9#diff-d6335c50f2d0536514781dc51d34f72a
-
As it turned out, this issue is related (but different system and bug manifestation):
http://forums.osclass.org/3-7-x/search-not-work-after-update-3-6-to-3-7-help-please!!!/
-
@_CONEJO
Sorry for delay, fix works.
-
@_CONEJO
I found next bug here. Parameters are being messed somehow.
I.e. try this:
- use default bender theme
- go to search page
- enter min price, i.e. 22
- parameter 22 is assigned to sPattern instead of sMinPrice
URL is:
...index.php?page=search&sOrder=dt_pub_date&iOrderType=desc&sPattern=22
Instead of:
...index.php?page=search&sOrder=dt_pub_date&iOrderType=desc&sMinPrice=22
-
Hi, try this fix here:
https://raw.githubusercontent.com/osclass/Osclass/0dfcea71a53b2b8b090e5846b53e26dca7fe8d66/oc-includes/osclass/classes/Rewrite.php
new:
https://raw.githubusercontent.com/osclass/Osclass/416a4a1370c8a1ac0de4112d3ddc233a10fa5f47/oc-includes/osclass/classes/Rewrite.php
-
@dev101
Now it does not mess any parameters, however if I pull some custom one here (let's say select with name "sCompany"), it is ignored.
-
Well, I also use a lot of custom params and they are all working on my end (with the latest change).
-
@dev101
I am taking this back, it was my mistake and my options in select did not have value set.
I can confirm that now problem is fixed.
-
Can we expect a quick update for the issues mentioned in this thread which do sound like some serious bugs?
(This besides some worrying threads about performance and search issue with 3.7 version)
Regards,
Eric
-
Hi Eric, this was already fixed in 3.7.1 unless you have/are reporting some new issues?
( P.S. Happy New Year :) )
-
Hi dev101 :)
Nope, no news from me regarding Osclass issues, I have been reluctant to upgrade since my whole system is running flawless (I think) and I have been looking at some other Open Source lately (Subrion CMS) so a little less attention here.The only thing missing is actual users..... :( Any thought on how to get ads posted, the whole system is free so price should not be an issue, nor the functionality. I wonder if the classifieds market might be 'done' due to established websites like Amazon/eBay/Marktplaats and many others here.
I hope you and everybody here have a wonderful 2017 with lots of fun and success! :D
I just noticed the new update in Admin and I think this will be a good moment to start a test case on my server. I have to see if my plugins still do what they're supposed to do and it'll be fun to work on though a LOT of work with regard to my current core fixes which I naturally did not document that wel except in code hehe
Thanks for all the hard work that went into the new releases again, if it wasn't for you guys Osclass would not be what it is today.
Talk to ya l8ter,
Eric