[SOLVED] How to solve the "zero" free price

[Aficionado]

Hi,

One of the major problems i have is that most posters of ads, give zero as price and then Free is displayed. Apparently they don't mean Free, they just don't want to give a price.

Any ideas how to solve or improve this ?

Thanks

[marius-ciclistu]

You could recplace the "free" word in language files with "ask for price".

[Aficionado]

You could recplace the "free" word in language files with "ask for price".

Tried that, BUT the price field is also shows at Items and the label was totally wrong to display.

Maybe i could inject a message in there, apart from the language file. Next to the Price field or above.

[marius-ciclistu]

Or you could prevent the input of 0 in the price's field to begin with.

[Aficionado]

Or you could prevent the input of 0 in the price's field to begin with.

Sure, if i knew how....

or even better if zero, then a "Are you sure it is Free"  dialogue. Still all those required extra coding, and i don't want to do that.

[marius-ciclistu]

If I would knew I would have wrote the solution in the previous post

But let's see:
oc-includes/osclass/helpers/hItems.php:   

Code: [Select]

/**
     * Formats the price using the appropiate currency.
     *
     * @param float $price
     * @return string
     */
    function osc_format_price($price, $symbol = null) {
        if ($price === null) return osc_apply_filter ('item_price_null', __('Check with seller') );
        if ($price == 0) return osc_apply_filter ('item_price_zero', __('Free') );

        if($symbol==null) { $symbol = osc_item_currency_symbol(); }

        $price = $price/1000000;

        $currencyFormat = osc_locale_currency_format();
        $currencyFormat = str_replace('{NUMBER}', number_format($price, osc_locale_num_dec(), osc_locale_dec_point(), osc_locale_thousands_sep()), $currencyFormat);
        $currencyFormat = str_replace('{CURRENCY}', $symbol, $currencyFormat);
        return osc_apply_filter('item_price', $currencyFormat );
    }
replace with

Code: [Select]

/**
     * Formats the price using the appropiate currency.
     *
     * @param float $price
     * @return string
     */
    function osc_format_price($price, $symbol = null) {
        if ($price === null || $price == 0) return osc_apply_filter ('item_price_null', __('Check with seller') );
       /* if ($price == 0) return osc_apply_filter ('item_price_zero', __('Free') );*/

        if($symbol==null) { $symbol = osc_item_currency_symbol(); }

        $price = $price/1000000;

        $currencyFormat = osc_locale_currency_format();
        $currencyFormat = str_replace('{NUMBER}', number_format($price, osc_locale_num_dec(), osc_locale_dec_point(), osc_locale_thousands_sep()), $currencyFormat);
        $currencyFormat = str_replace('{CURRENCY}', $symbol, $currencyFormat);
        return osc_apply_filter('item_price', $currencyFormat );
    }
I'll make this to my website as well. Thank you.

[Aficionado]

This is the change ?

Code: [Select]

/* if ($price == 0) return osc_apply_filter ('item_price_zero', __('Free') );*/

[marius-ciclistu]

        if ($price === null || $price == 0) return osc_apply_filter ('item_price_null', __('Check with seller') );
       /* if ($price == 0) return osc_apply_filter ('item_price_zero', __('Free') );*/

[Aficionado]

        if ($price === null || $price == 0) return osc_apply_filter ('item_price_null', __('Check with seller') );
       /* if ($price == 0) return osc_apply_filter ('item_price_zero', __('Free') );*/

right. got it. thanks i will change it during the weekend.

 

[marius-ciclistu]

This forum is great:)) I'm learning alot from it even if sometimes I teach my self with the help of others that are just asking:)) (But also I learned alot from others that posted solutions)

So a big THANK YOU to all !

[Aficionado]

This forum is great:)) I'm learning alot from it even if sometimes I teach my self with the help of others that are just asking:)) (But also I learned alot from others that posted solutions)

So a big THANK YOU to all !

Nice also to see people like you, that offer help the community of Osclass. 

[marius-ciclistu]

I received help so I give help when and if I can.... I liked the idea of the man behind linux in comparison with Bill G.

[calinbehtuk]

If i understand right, you want to change the free text or make some changes on that level free?
You don't have to change the core files, you have some filters in formatted price that you can use.
For example for changing the free tag with the price and symbol:
this in your theme functions.php file

Code: [Select]

function new_filter_for_free_price(){
    return osc_item_price().' '. osc_item_currency_symbol();
}

osc_add_filter ('item_price_zero', 'new_filter_for_free_price');

Of course that you can play more with this

Code: [Select]

function new_filter_for_free_price(){
    return __('your text');
}

In this way you don't have to make this changes every time you update osclass.

You have more filters there that you can use in the same way.

osc_add_filter ('item_price_null', 'your function' ); - for check with seller

osc_add_filter('item_price', 'your function' ); - for final price

[marius-ciclistu]

Calin,
This is nice in case the user didn't change osclass files.

But as I saw, there are many that made changes ( like me) , so they can choose the best solution for them from these 2.

PS. While updating, the theme is not updated as well?

[calinbehtuk]

@marius-ciclistu I think the best way to make the changes it avoid to change osclass core or theme files. You can create a plugin in just a few steps and include all your changes in the plugin, so in this way your core files and theme files will not be changed and you will not have to do this changes on each update.