Osclass forums
Support forums => General help => 3.7.x => Topic started by: marius-ciclistu on July 11, 2017, 02:06:47 pm
-
Hi,
Some of us run osclass with changes to the theme /core files and when it comes to update to the latest version, it seems difficult to remake those changes as it takes a lot of time/tests.
A list of changes would ease the job when updating, even if this list contains only the fixes for vulnerabilities and bugs, leaving aside the upgrades.
Thank you.
-
I think you can do that using Github for Osclass core.
I'm not an expert with features of Github but i do know people that do that.
For Themes, use Code Compare or WinMerge freeware software.
-
Thank you.
With github I resolved a bug regarding the alerts, if I remember right, that is not in the 3.7.3 and was in 3.7.1 (Conejo was the author).
I'm not an addict whith the updates, but at least the vulnerabilities must be resolved from time to time.
-
https://github.com/osclass/Osclass/compare/v3.7.1...v3.7.3
But I suggest not to modify the core and use plugins instead, 99,99% of the time it could be solved by a plugin. And if you really need to modify the core, if you expose your case, why you need it, the user-case, etc etc, we could accept the change into the core.
-
Thank you for the link.
If I expose my case some of the payed plugins would lose their purpose... and I don't want to "harm" the income of the guys that worked and deserve to sell the plugins. And regarding ft_min_word_len =4 , my site searches for even 1character words with some modifications in theme and core files.
Recently I had to update a joomla website because of some vulnerabilities, and I asked this to prevent those cases, as you said in the forums at a certain point that 3.7.3 has no known vulnerabilities.
I could install a fresh osclass 3.7.3 and remake the +50 (without css /sass)modifications to it, but that takes a lot of time.
Edit. From changelog, if there are no vulnerabilities fixes yet, there is no point in updating yet, in my case anyway.
Thank you again.
-
Thank you for the link.
If I expose my case some of the payed plugins would lose their purpose... and I don't want to "harm" the income of the guys that worked and deserve to sell the plugins. And regarding ft_min_word_len =4 , my site searches for even 1character words with some modifications in theme and core files.
Recently I had to update a joomla website because of some vulnerabilities, and I asked this to prevent those cases, as you said in the forums at a certain point that 3.7.3 has no known vulnerabilities.
I could install a fresh osclass 3.7.3 and remake the +50 (without css /sass)modifications to it, but that takes a lot of time.
Then, what you want to achieve it doable with plugins, without modifying the core.
You should also start using git, so you could cherry pick and keep track all of the changes, and apply them automatically instead of manually modifying the files
-
You are right, but I'm not yet at that level to create plugins.
Regarding the git, I'll try to learn how to deal with it.
Thank you for osclass script. It is a big opportunity for me to learn more by modifying it.
-
Apologies for being off-topic now but I can't keep quiet.
Out of experience, Osclass IS a great script once you get the hang of it.
Thanks to Osclass I have learned php (still learn) and I also still like to play around with it on an almost daily basis.
I try to improve things or come up with cool additions in either plugins or simply by sharing it here in forums. Sometimes I come up with something which is already taken care of and then I have to re-analyse to figure out why I missed it haha
In short, Osclass is just a great script imo, still being improved and modernized and most important of all it does the job it is supposed to do! We might not be as popular as Wordpress but I know Wordpress also and NO WAY I would start a classifieds website using Wordpress. Osclass is the place to be!! Yes there are some good others as well but those are way more commercial.
Osclass offers all basics to start a nice classifieds website. And I believe it still has great potential! :)
I see how enthousiastic you are in the forums and it makes me smile, I think you're 'hooked' like myself and some die hard others ;)
You are right, but I'm not yet at that level to create plugins.
Regarding the git, I'll try to learn how to deal with it.
Thank you for osclass script. It is a big opportunity for me to learn more by modifying it.
-
SmaRTeY you are right. That is why I like to give answears to others if I know, and that is why i shared the code for using osclass with ft_min_word_len=4 while being able to search one character word. This was my first big modification to the script and I couldn't have done it without the help of others that shared knowledge on web.
Also I'm paying attention to not disturb the payed plugins with my posts.
Thank you.
-
Cool, in case you want to create your own plugins and you haven't seen this doc yet, it's the basics and very easy to understand once you also take a look at the free (or payed) plugins at the same time 8)
https://doc.osclass.org/How_to_create_a_plugin
SmaRTeY you are right. That is why I like to give answears to others if I know, and that is why i shared the code for using osclass with ft_min_word_len=4 while being able to search one character word. This was my first big modification to the script and I couldn't have done it without the help of others that shared knowledge on web.
Also I'm paying attention to not disturb the payed plugins with my posts.
Thank you.
-
I saw it, but the fact that I saw many times plugin conflicts in these forums, made me modify the osclass files directly. Anyway I have a simple osclass with basic functionalities like mass item prolongation, expired/active items display, alerts showing by searched word in user dashboard-and when de user deletes that alert, the alert email field changes to 'deleted' in admin so I can filter them and delete them and so on. Many of these functionalities have plugins, some free some payed, but i rather not use them.
EDIT: and my osclass sends only 1 email/hour, even if in that hour expires 1 or 100 ads, 1 hour AFTER the ad expired.
-
Well, there's a lot of ways how to use the script but one thing is for sure, the more changes you create in core files the less easier it gets to maintain when Osclass updates it's code. Therefor you can best use additional functions in your functions.php in your theme folder in my experience and some core changes you can not do in an easy other way so you do have to keep track of your changes.
-
I have a .txt file with all the changes I've made, but until now 3.7.1 has no vulnerabilities so it's fine.
-
I use both a 'Maintenance' file and keep track in files themselves which seems to work out best in my case.
I enter (default) comment (tag) in files I change including reason and saving old code so when doing a file compare it's easy to decide what to do.
I have a .txt file with all the changes I've made, but until now 3.7.1 has no vulnerabilities so it's fine.
-
Yes, but that exposes the php code (anyway oc is opensource but.. if I don't know it all, better not take the risk.)
-
Well, I agree so I decided to create a production version with stripped comments and one dev including my comments. 8)
I am working on a commercial plugin at the moment and two more ideas in my mind but I already found a nice snippet I can use to auto-strip comments from php files which I will probably also turn into a simple yet effective (free) plugin for this.
-
I'm glad our discussion is proactive and gives you new ideas:)
-
Sure, new ideas are nice especially if they contribute to others as well. Same as getting rid of *all* bugs/notices/warnings etc. in existing core/themes/plugins code. :)
I'm glad our discussion is proactive and gives you new ideas:)
-
Sure, new ideas are nice especially if they contribute to others as well. Same as getting rid of *all* bugs/notices/warnings etc. in existing core/themes/plugins code. :)
I'm glad our discussion is proactive and gives you new ideas:)
Sure, as long as new ideas etc etc FIND their way (some of them at least) to the CORE. And they NEVER DO.
-
Sure, new ideas are nice especially if they contribute to others as well. Same as getting rid of *all* bugs/notices/warnings etc. in existing core/themes/plugins code. :)
I'm glad our discussion is proactive and gives you new ideas:)
Sure, as long as new ideas etc etc FIND their way (some of them at least) to the CORE. And they NEVER DO.
Nothing stopes me to put them there. :)
-
Nothing stopes me to put them there. :)
Of cource and my comment was not directed to you.
;)
-
Ok. Sorry ;) My bad.
-
Ok. Sorry ;) My bad.
No problem. Actually i'm here for several years and i haven't seen a single request to be added to the core, EVER.
The usual reply (if any) is that a plugin should be created for that, or it is not needed, or to post a request to usersvoice crapolla service.
So at some point myself (and others) stopped to post suggestions and requests (the related forum is closed as you can see).
Osclass team have their own agenda and we have no saying in all that. Also we have no idea of what the future will bring.
-
Ok. Sorry ;) My bad.
No problem. Actually i'm here for several years and i haven't seen a single request to be added to the core, EVER.
The usual reply (if any) is that a plugin should be created for that, or it is not needed, or to post a request to usersvoice crapolla service.
So at some point myself (and others) stopped to post suggestions and requests (the related forum is closed as you can see).
Osclass team have their own agenda and we have no saying in all that. Also we have no idea of what the future will bring.
I've read about this in other messages that you've posted.
We must agree that something free can't and WON'T be allowed to compete with sites like olx for example. This is the simple obvious reason, not bad will etc. The money are "Talking".
I'm glad this script is as it is, because it allowed me to learn incredibly many new things about php in the time I've spent improving it. It's like a car's body shell that's missing pieses and you have to improve/build it to be able to use it , but most important, it ofers the tools to do it, you just have to be good at it, and persistent. In this way the result is payed with hard work.
-
We must agree that something free can't and WON'T be allowed to compete with sites like olx for example. This is the simple obvious reason, not bad will etc. The money are "Talking".
Why ?
While we can't compare Wordpress size with Osclass, Wordpress is free, isn't it ?
That hasn't stopped Wordpress from been improved, have a roadmap and also accept (limited to be honest) suggestions from the community.
Anyway, Osclass is still very good of cource.
-
We must agree that something free can't and WON'T be allowed to compete with sites like olx for example. This is the simple obvious reason, not bad will etc. The money are "Talking".
Why ?
While we can't compare Wordpress size with Osclass, Wordpress is free, isn't it ?
That hasn't stopped Wordpress from been improved, have a roadmap and also accept (limited to be honest) suggestions from the community.
Anyway, Osclass is still very good of cource.
Because olx is making alot of money, they've just released a new functionality for payed advertisments into their website. In Romania they've bought all the major competition (there were 2 big websites battling some years ago, they camed , bought the first one and then bought the second one, and then, they imposed limits and taxes for ads=> that is the reason I found osclass).
EDIT: I have a frind that workes at a company that deals exclusively with wordpress ( i dislike wp anyway), so that script brings alot of income. The company is USA based.
-
Because olx is making alot of money, they've just released a new functionality for payed advertisments into their website. In Romania they've bought all the major competition (there were 2 big websites battling some years ago, they camed , bought the first one and then bought the second one, and then, they imposed limits and taxes for ads=> that is the reason I found osclass).
EDIT: I have a frind that workes at a company that deals exclusively with wordpress ( i dislike wp anyway), so that script brings alot of income. The company is USA based.
Ok but OLX is not a development company for some script. Like Osclass or Wordpress.
Why compare a SERVICE (OLX) with a script ?
As for OLX, it is full of scam ads and shut down in my country. Same for Adoos and Slando.
-
I don't know them all....but "Follow the money" is an universal true expresion in all cases, so let's enjoy the fact that we have what we have, and let others bother about all the rest.
Imagine if osclass wouldn't have been around even in the shape that it is..... the IT bussiness is a wealthy one, so the people that work @ osclass must be payed. If you include all the new good ideas into the free core who will buy the plugins? How would they pay their people that are working on it?
You start understanding more things when you have, say 1-10-20-300 people that you must pay each month.... their families don't care about what they do at work..they only care about the money, so that they may live.
Now comparing wp with osclass, their purpose are different. WP has a wider usability that a classifields has. It's like developing windows vs linux in the games' behalf. You can't play games on Ubuntu so that's why windows is winning here.
-
Imagine if osclass wouldn't have been around even in the shape that it is..... the IT bussiness is a wealthy one, so the people that work @ osclass must be payed. If you include all the new good ideas into the free core who will buy the plugins? How would they pay their people that are working on it?
You start understanding more things when you have, say 1-10-20-300 people that you must pay each month.... their families don't care about what they do at work..they only care about the money, so that they may live.
The answer is actually simple for the above. Something that doesn't move forward, doesn't stay static for a long time. It dies. Slowly maybe, but it dies.
Why include some things in the core ? Nice question.
Because some things MUST be in the core. Imagine Wordpress without an editor in the core for example.
Have you EVER seen a Classifieds site WITHOUT an option to RENEW the ads for example ?
:o
-
The answer is actually simple for the above. Something that doesn't move forward, doesn't stay static for a long time. It dies. Slowly maybe, but it dies.
Why include some things in the core ? Nice question.
Because some things MUST be in the core. Imagine Wordpress without an editor in the core for example.
Have you EVER seen a Classifieds site WITHOUT an option to RENEW the ads for example ?
1. You are right.
2-3. No comment.
4.Yes I have. Osclass:))) I was stunned:)) but this is life, it surprizes you sometimes. Anyway from the info I gathered, osclass is the best there is among open source clasifields scripts available at the moment.
-
Hmmm, this is going a bit off-topic but ohwell.
I think it is allowed to 'Fork' Osclass on Github and start a seperate development track like Open Office => Libre Office and many other scripts.
So if there are people willing to do so..... 8)
On the other hand, Osclass offers theme and plugin creators a lot of opportunities to expand or change functionality and make a little money for the coding that goes into it. I do agree that the renewal functionality could be implemented in core with some specific admin configuration options but here also, a plugin can do the same. Having plugins being able to do this it also means more renewal functionality options to chose from instead of having 1 core (static) renewal functionality in place.
_CONEJO has mentioned this as well, there are MANY wishes when it comes to renewal of ads and as such there's never 1 'system' satisfying the mass so therefor it seems smart to have several plugins available where future Osclass admins can chose from.
So what could be *nice* to do in this case is add a *free* basic renewal plugin. This would mean Osclass not missing this basic option yet still offering plugin creators to come up with more advanced alternatives to chose from, win-win? I mean it is nice we are offered a Google Map plugin but I think many would rather have a free basic renewal plugin.
For theme & plugin creators Osclass is a big opportunity but it needs to focus on getting more marketshare in the classifieds 'market'.
I think Osclass should set out for becoming the #1 Classifieds script. No doubt whether to go for any other (free) script when it's about classifieds... there can be only one! (I love the 'Highlander' series) :D
-
Eric,
We are OT but then there is NO forum for general chat about all that (why ?).
Also my "renew" feature was just an example, since it is the more striking one. The second is the Editor. Isn't a good editor part of any core of a CMS ?
I could go on with other features but i guess we all know all that but most don't want to talk about publicly.
An other good example is static page caching for the ads. That only could solve 99% of the speed problems, since ads almost never change until deleted.
-
Haha, I consider this 'general help' ;)
Well, as I mentioned in other thread, Osclass needs to find and keep balance between 'core' script and what can be offered through plugins and/or themes. Just remember that also theme creators are allowed to offer a better editor with their themes, this is not solely an Osclass core option. Plus there is at least 1 good plugin alternative for editing from dev101.
The static page caching I consider a more 'basic' feature and I would like to see this improved in core as well....somehow.
There could be more and I think it's important to be frank and open about it and to adopt certain things into core but also stay 'basic'.
Eric,
We are OT but then there is NO forum for general chat about all that (why ?).
Also my "renew" feature was just an example, since it is the more striking one. The second is the Editor. Isn't a good editor part of any core of a CMS ?
I could go on with other features but i guess we all know all that but most don't want to talk about publicly.
An other good example is static page caching for the ads. That only could solve 99% of the speed problems, since ads almost never change until deleted.
-
Haha, I consider this 'general help' ;)
I came to Osclass around 2011-12 after 6 years with this
http://www.4u2ges.com/classified_software_features.asp
an Microsoft ASP script (now discontinued for ages). Considering the script was first introduced around 2004, it was extremely advanced.
-
Why is Osclass missing X feature?
We want to make Osclass as flexible as possible, so when there are multiple solutions of vews about something, we prefer to left space for plugins.
Renewal: Renew a listing should have the same ID? a different ID? could an user renews unlimited times a listings? should we limit the renews per day/month/... ? Does renews cost money? how much? how does the user pay? ... There are multiple questions and configuration for this feature, including it in the core would make the admin more complex (lots of settings) and harder to maintain/develop.
Editor: There are multiple "editor" out there, from tinyMCE; CKEditor, aloha, webodf, mercury and those are the heavy weight, there are even more not so famous like froala wymeditor, jhtmlarea, squire,.... why limit to one? why not let you choose which one do you want/need?
Are "payments" important to a classifieds website? yes, but again, how we do implement it? there are many people asking for many different features and payment processors, including it in the core will not please everyone, make harder to maintain/develop/update, ... And this happens with a lot of features. Imagine there's some issue with some of this and you are required to update your whole website because it's a core feature.
I really would like to see more developers doing this kind of plugins
-
Renewal: Renew a listing should have the same ID? a different ID? could an user renews unlimited times a listings? should we limit the renews per day/month/... ? Does renews cost money? how much? how does the user pay? ... There are multiple questions and configuration for this feature, including it in the core would make the admin more complex (lots of settings) and harder to maintain/develop.
The fact is that there is no Renew plugin, apart from one of Cartagena68's that is not even available at Market.
-
Editor: There are multiple "editor" out there, from tinyMCE; CKEditor, aloha, webodf, mercury and those are the heavy weight, there are even more not so famous like froala wymeditor, jhtmlarea, squire,.... why limit to one? why not let you choose which one do you want/need?
I consider that an editor shoud/could be in the core.
Instead of that, we have an exteremly outdated plugin (RichTextEditor) that use a hack (as dev101 said) and also a second instance of TinyMCE (also very old) for the admin part.
And to close all this, do you ever TALK to any developer from here ? Because they may not post here (and leave me take all the blast) BUT in private some of them ask/talk about all that. Deeply.
Because we care.
-
Working on more plugins.... :)
I really would like to see more developers doing this kind of plugins
-
I agree with Aficionado that it should be there considering the need for the script being up-to standards but I don't care if it is core or plugin.
I also agree with _CONEJO with regard to having more options available with plugins than 1 in core (which indeed also has to be maintained and it IS Open Source so time related to keeping the script up-to-date IS of the essence).
Now I don't know about the CKEditor(?) plugin dev101 created but that looks like a decent editor to me, it has good reviews from what I could see so is there really the need for a new plugin that is actually the same and already available??
I consider that an editor shoud/could be in the core.
-
My oppinion is to deliver osclass with some free usefull plugins for basic needs as opencart script does. In this way both sides can be pleased.
Oh and with core fixes for not working subject in email_send_friend kind of stuff.
PS.
By the way the google map plugin has something in 3.7.1 because I couldn't get it to work even if i generated the API from google, so I disabled it.There are some topics in forums about that, but for me that plugin is irrelevant.
-
I agree with Aficionado that it should be there considering the need for the script being up-to standards but I don't care if it is core or plugin.
I also agree with _CONEJO with regard to having more options available with plugins than 1 in core (which indeed also has to be maintained and it IS Open Source so time related to keeping the script up-to-date IS of the essence).
Now I don't know about the CKEditor(?) plugin dev101 created but that looks like a decent editor to me, it has good reviews from what I could see so is there really the need for a new plugin that is actually the same and already available??
So what you actually say is that in 2017, we must have a third party Editor plugin for Osclass ? Or stay with a very-very old version of TinyMCE (Richtext Editor plugin) ?
-
Hmmm, I don't know what's wrong with the use of a third party editor, I think WP also uses 3rd party editors in their editor plugins and there are many available, all offered as plugin. But there is one added for free to basic scripts.
Anyway, I mentioned up-to-standards, if this can simply be achieved with a plugin that would be fine by me. But I do think Osclass needs to be alert on their 'assets'. Take JQuery for example, Osclass is still on 1.x while we have JQuery 3.2.1 now as latest lib. So it would be nice to see Osclass move forward on this matter since browsers also keep moving forward. Interesting read: https://stackoverflow.com/questions/38129003/jquery-1-vs-jquery-3-legacy-browser
My up-to-standard definition is: modern / responsive / quality / easy in use and simply doing the job it's expected to do.
Even a 3rd party plugin that offers the UX needed to publish great ads would be just fine imo.
I agree with Aficionado that it should be there considering the need for the script being up-to standards but I don't care if it is core or plugin.
I also agree with _CONEJO with regard to having more options available with plugins than 1 in core (which indeed also has to be maintained and it IS Open Source so time related to keeping the script up-to-date IS of the essence).
Now I don't know about the CKEditor(?) plugin dev101 created but that looks like a decent editor to me, it has good reviews from what I could see so is there really the need for a new plugin that is actually the same and already available??
So what you actually say is that in 2017, we must have a third party Editor plugin for Osclass ? Or stay with a very-very old version of TinyMCE (Richtext Editor plugin) ?
-
Hmmm, I don't know what's wrong with the use of a third party editor, I think WP also uses 3rd party editors in their editor plugins and there are many available, all offered as plugin. But there is one added for free to basic scripts.
Anyway, I mentioned up-to-standards, if this can simply be achieved with a plugin that would be fine by me. But I do think Osclass needs to be alert on their 'assets'. Take JQuery for example, Osclass is still on 1.x while we have JQuery 3.2.1 now as latest lib. So it would be nice to see Osclass move forward on this matter since browsers also keep moving forward. Interesting read: https://stackoverflow.com/questions/38129003/jquery-1-vs-jquery-3-legacy-browser
My up-to-standard definition is: modern / responsive / quality / easy in use and simply doing the job it's expected to do.
Even a 3rd party plugin that offers the UX needed to publish great ads would be just fine imo.
I'm afraid there are a lot of things that are VERY OLD with Osclass. Not only JQ version.
-
I agree and I hope Osclass 'team' will focus on Bender theme quality (php7.1+), more 'hooks' and 'assets' LifeCycleManagement coming release(s).