count(): Parameter must be an array or an object that implements Countable

[jerry singh]

That's the error am geeting in error log, osclass 3.7.4
Php am using- 7.2

count(): Parameter must be an array or an object that implements Countable in
osclass/helpers/hSearch.php on line 342

[Aficionado]

Don't use 7.2.

PHP 7.0.x for me works 100%, some say 7.1 also works ok (not for me).

[Aficionado]

Searching for that error with google, shows a lot of such problems. 7.2 incompatibility with older code.

[dev101]

Yes, this is either a bug in 7.2.0 or they really changed the way it works with null. Don't worry about it.

As I don't know yet what would be the best way to fix it (because, if it gets "fixed" in PHP 7.2.1 or so, then nothing should be fixed in Osclass part). If they make this behavior permanent in PHP, then it will be easy to deal with it, but it is best to wait for now.

Regards

[jerry singh]

hi @dev101,

this bug gets fixed,
check out- https://github.com/FriendsOfPHP/Sami/issues/302
and https://github.com/FriendsOfPHP/Sami/commit/742f2575c6382c8a362c3c99974399de382bfa63

Code: [Select]

  if (null !== $this->versions && count($this->versions)) { // <= here

Code: [Select]

public function add($version, $longname = null)
     {
        if (count($this->versions)) {
        $countable = is_array($this->versions) || $this->versions instanceof \Countable;

        if ($countable && count($this->versions)) {
             throw new \LogicException('A SingleVersionCollection can only contain one Version');
         }

Code: [Select]

function osc_search_url($params = null) {
        if(is_array($params)) {
            osc_prune_array($params);
        }
        $countP = count($params);
        if ($countP == 0) { $params['page'] = 'search'; };
     
may be above solution will fixed this non-countable count($params) error 

[dev101]

I don't see it on bugs.php.net.

[jerry singh]

may be its not bug; of php 7.2

error occured due to updating newer version of php.

please have a look - https://github.com/FriendsOfPHP/Sami/issues/302
and https://github.com/FriendsOfPHP/Sami/commit/742f2575c6382c8a362c3c99974399de382bfa63

hope this will help you to sort out this error. 

[dev101]

I'm only interested in official PHP bug tracker, not other unrelated projects.

[Aficionado]

Nothing needs to be sorted out for now. Just use PHP 7.0.x.

Simple as that.

[dev101]

I have tested PHP 7.2.1 RC1 and seems to behave the same.
This change will not break things, as return is still 0 (same as before), but with annoying warning. Even empty strings will raise it.

So, the easiest fix for this is to replace:

Code: [Select]

function osc_search_url($params = null) {
with:

Code: [Select]

function osc_search_url($params = array()) {
lazy alternative:

Code: [Select]

function osc_search_url(@$params = null) {
Regards

[jerry singh]

 
@dev101

thanks! for sort out this error,  but  still theres lot of issue with php 7.2 (osclass)

[Aficionado]

@dev101

thanks! for sort out this error,  but  still theres lot of issue with php 7.2 (osclass)

Then don't use 7.2. If you are not just testing, don't use it. Use 7.0.x.

[dev101]

I have briefly tested 7.2.0 and besides this one, one other thing needs fixing, but didn't notice other issues (though it was a brief test).
Your issue with HTTP_HOST in other topic might not directly be related to PHP 7.2.0 (I don't see why it should be), and for other issues you have regarding PHP 7.2 you can report in new separate topics here or at github.

[Aficionado]

@dev101


https://forums.osclass.org/3-7-x/osclass-3-7-4-and-php-7-2/msg158734/#msg158734

[dev101]

Thanks, I've read it before, but forgot it in the meantime...