Osclass forums

Support forums => Themes => Bender => Topic started by: greg2012 on August 29, 2013, 09:42:20 am

Title: Place holder issues with Bender Black theme
Post by: greg2012 on August 29, 2013, 09:42:20 am

For months (even before the release of 3.2.1 ) people have been complaining about the fact that you can't change the placeholder (which currently says IE PHP PROGRAMMER) and there is still no resolution to the problem.

You can change what you would like the text to read, or UNTICK the footer link option (which will display the "OSCLASS" credit) but when you click "SAVE CHANGES" It always come back to the same.

Reminds me of the movie Ground hog day - where you start the same day the same way as yesterday.

Regards

Gregory

Title: Re: Place holder issues with Bender Black theme
Post by: mmcsus on September 01, 2013, 03:11:48 pm

Hi Gregory,

Quote

You can change what you would like the text to read, or UNTICK the footer link option (which will display the "OSCLASS" credit) but when you click "SAVE CHANGES" It always come back to the same.

Carlos corrected this issue some time ago.

I just checked using Osclass 3.2 bender 1.0 and it works as expected.

Reference: oc-admin --> Appearance --> Theme settings

David

Title: Re: Place holder issues with Bender Black theme
Post by: mmcsus on September 01, 2013, 08:03:09 pm

Hi Gregory,

Just went and checked bender_black and you are correct but that was solved with the release of bender 1.0.

You just have to wait for the release of bender_black 1.0 or simply do the following:

Go to oc-content/themes/bender_black/functions.php find:

Quote

FUNCTIONS

*/

    // install update options
    if( !function_exists('bender_blackBodyClass_theme_install') ) {
        function bender_black_theme_install() {
            osc_set_preference('keyword_placeholder', __('ie. PHP Programmer', 'bender_black'), 'bender_black_theme');
            osc_set_preference('version', BENDER_BLACK_THEME_VERSION, 'bender_black_theme');
            osc_set_preference('footer_link', '1', 'bender_black_theme');
            osc_set_preference('donation', '0', 'bender_black_theme');
            osc_set_preference('default_logo', '1', 'bender_black_theme');
            osc_reset_preferences();
        }
    }

    if(!function_exists('check_install_bender_black_theme')) {
        function check_install_bender_black_theme() {
            $current_version = osc_get_preference('version', 'bender_black');
            //check if current version is installed or need an update<
            if( !$current_version ) {
                bender_black_theme_install();
            }
        }
    }

Change to:

Quote

FUNCTIONS

*/

    // install update options
    if( !function_exists('bender_blackBodyClass_theme_install') ) {
        function bender_black_theme_install() {
            osc_set_preference('keyword_placeholder', __('ie. PHP Programmer', 'bender_black_theme'), 'bender_black_theme');
            osc_set_preference('version', BENDER_BLACK_THEME_VERSION, 'bender_black_theme');
            osc_set_preference('footer_link', '1', 'bender_black_theme');
            osc_set_preference('donation', '0', 'bender_black_theme');
            osc_set_preference('default_logo', '1', 'bender_black_theme');
            osc_reset_preferences();
        }
    }

    if(!function_exists('check_install_bender_black_theme')) {
        function check_install_bender_black_theme() {
            $current_version = osc_get_preference('version', 'bender_black_theme');
            //check if current version is installed or need an update<
            if( !$current_version ) {
                bender_black_theme_install();
            }
        }
    }

David

Title: Re: Place holder issues with Bender Black theme
Post by: greg2012 on September 02, 2013, 10:20:30 am

Hey David,
Thanks for attempting to solve the problem. I'm glad you double-checked and realised there really was a problem.

I applied your solution. The following happend:

Warning: Cannot modify header information - headers already sent by (output started at /home/content/62/9437062/html/oc-includes/osclass/utils.php:1697) in /home/content/62/9437062/html/oc-includes/osclass/utils.php on line 1699

However on the actual site, the changes were effected.
Any idea why this is happening?

Greg

Title: Re: Place holder issues with Bender Black theme
Post by: mmcsus on September 02, 2013, 04:02:49 pm

Hi Greg,

Yes, in the code I gave you find:

Quote

osc_set_preference('keyword_placeholder', __('ie. PHP Programmer', 'bender_black_theme'), 'bender_black_theme');

Change to:

Quote

osc_set_preference('keyword_placeholder', __('ie. PHP Programmer'), 'bender_black_theme');

I don't see your issue on my end but I think the above will correct it, please let me know.

David

Title: Re: Place holder issues with Bender Black theme
Post by: greg2012 on September 03, 2013, 10:50:36 pm

Hey David,
Many thanks for your efforts. I have decided to wait until the updated Bender Black theme comes along. It seems that when you fix one problem with that version, another line error pops up.

I'm also noticing with the Bender Blue - that there are some omissions. I will start a new post on it. I'd appreciate if you have a look.

Greg