Osclass forums
Development => Development => Topic started by: navjottomer on December 05, 2017, 02:42:56 pm
-
Hi Guys,
I have recently created experimental fork of official osclass repo at https://github.com/navjottomer/Osclass
I started with refactoring old code and removing legacy code in Osclass and in future will try to add features, other's can also contribute to this repo by testing alpha release, creating issue or submitting pull request.
I will try to close as many issues I can in my free time, but I greatly need help of other developers who want to contribute in this repo.
Objective of this repo is to test new features and improving code quality in osclass, later we will create pull request to official Osclass repo.
Regards
Navjot tomer
-
Just be sure Osclass team AREN'T doing the same thing, in their offices, right now.
I mean don't do work/updating/refactoring that they are already doing (without updating Github).
-
Which I cannot be sure ;) without any official notification.
But it would be much better if people create pull request to this repo and after testing via community we create pull request to official one. We can add maintainer to this repo from community, who can decide what should be included and when. It will surely reduce work of official osclass repo maintainers.
We already know that official public repo is not touched in a while, if any core-dev can answer on this thread that how we can contribute more to this project.
I have already made over 65 commits to my repo so I will carry on what I am doing right now.
Regards
-
Just to be clear. I'm not saying "don't do it".
Au Contraire.
-
Ofcourse you didn't said that.
-
I'm not a programmer. I checked your github fork, and i was surprised to see the ammount of work you did.
I can't comment on the quality of it (i'm not qualified), but great thanks for your work and your interest in Osclass.
I wish this effort will be in benefit of Osclass and all of us.
:)
-
Thanks!! Really appreciated. But you can always help by testing and reporting issue.
Regards
-
Thanks!! Really appreciated. But you can always help by testing and reporting issue.
Regards
And i will do so, if you let us know how ? I mean is it ready for test ? Where and how should we report something ?
Also did anyone from Osclass contacted you ? Anything from them ?
-
And i will do so, if you let us know how ? I mean is it ready for test ? Where and how should we report something ?
Also did anyone from Osclass contacted you ? Anything from them ?
You can check this page about how to create new issue https://help.github.com/articles/creating-an-issue/
You can get release from release section of GitHub page and test it in your local environment. Before reporting issue check if it is already fixed in later commit or not.
Keep in mind in starting stage we are more focused on errors not on feature. Because my first goal is to clean osclass code and than update few libraries osclass depends on.
Although I am not saying that you are limited to report errors only, you can create any issue just don't expect that it will be closed before our main goal( It may though).
From osclass team no one has contacted me yet but I have only posted about this yesterday So it is not their fault in anyway.
-
Hi. Sorry to ask but recentry I've read about drupal for example, and your description from here is verry similar with drupal's description, in the sense that it doesn't tell you concrete things, only a "nice story".
For example, it would be easier if you gave us some points of interest like: does your version strip the normal osclass of more features that it already doesn't have (excepting the plugins).
Take it as an observation with positive intention:).
Thank you.
-
Hi. Sorry to ask but recentry I've read about drupal for example, and your description from here is verry similar with drupal's description, in the sense that it doesn't tell you concrete things, only a "nice story".
For example, it would be easier if you gave us some points of interest like: does your version strip the normal osclass of more features that it already doesn't have (excepting the plugins).
I don't see what "Drupal" has to do with this ReFactroring fork.
I think Navjottomer explained in details what his project is and what not.
-
Only the description style. I for example did not understood what this fork is about by reading the above topic.
If I looked on github at some of the comits, I saw that he cleaned up the code for unnecesary brakets, parantesisis and other lines of code.
Osclass has many bugs that I resolved in my instalation, so if I would to use/test a new 'distribution' of osclass I would like to know the changes in functionality at least.
-
Only the description style. I for example did not understood what this fork is about by reading the above topic.
If I looked on github at some of the comits, I saw that he cleaned up the code for unnecesary brakets, parantesisis and other lines of code.
Osclass has many bugs that I resolved in my instalation, so if I would to use/test a new 'distribution' of osclass I would like to know the changes in functionality at least.
I think the following describes 100% the purpose of the fork.
I started with refactoring old code and removing legacy code in Osclass and in future will try to add features,
-
refactoring old code and removing legacy code
These words made me write an answer :)
Refactoring old code - ok...I could imagine what that is.
Removing legacy code - I have no ideea what that does.
(I'm trying also to learn from this, so don't think my intentions are negative).
-
refactoring old code and removing legacy code
These words made me write an answer :)
Refactoring old code - ok...I could imagine what that is.
Removing legacy code - I have no ideea what that does.
(I'm trying also to learn from this, so don't think my intentions are negative).
I think if you look closely the Github fork you will understand fully what it is for.
-
Removing legacy code means Updating libraries using php4 era syntax. Using modern php5 functions. It is work in progress so I can't comment on what we remove and what we include. I just need help and suggestions right now. It will we morr clear when we achieve our first goal.
Regards
Navjot
-
Thank you. I thought that refactoring old code meant that you update the code acc to newer php versions. Thank you for clarifying.
-
I don't see much interest. Anyway.
Just finished backup my online dev installation (home dir AND Database). I will upload the updated files from Github in a while and see how it goes.
I will update here with a summary asap.
-
I don't see option to create an Issue at Github, so ...
After playing a bit with the experiment version and Bender, i only see a lot of this Notice:
[09-Dec-2017 20:30:15 Europe/Madrid] PHP Notice: Array to string conversion in /home/oc-includes/osclass/helpers/hSanitize.php on line 183
-
An issue: Switching from bender to OsclassWizards theme, i see this:
[09-Dec-2017 20:36:37 Europe/Madrid] PHP Notice: Plugin osclasswizards is missing the index.php file /home/oc-content/plugins/osclasswizards/index.php in /home/oc-includes/osclass/classes/Plugins.php on line 124
The Osclasswizards is untouched and i REinstalled it from Market. And Index.php is not missing, it is there.
-
Thanks I will work it. What version of php you are using?
-
Thanks I will work it. What version of php you are using?
I'm using PHP 7.0.26
-
Thanks I will work it. What version of php you are using?
Also allow Issues to github if you want reports in there.
-
Thanks I will work it. What version of php you are using?
Also allow Issues to github if you want reports in there.
Oops I forget that, enabled now.
-
Ok I try to reproduce error on both php5.6 and php7.1 and didn't get any error. I tested it on default installation(no other plugin only stock, with one example ad) with bender theme, can't comment on osclasswizards as I don't have it.
More info will be needed to resolve it. I have enabled issues on github, so we can discuss it their.
Regards
-
OsclassWizards is free, you can get it and test it.
As for the rest, i also have no plugins installed but i run 7.0 and not 7.1.
-
Should i start with a clean db ?
Because i didn't. I used the 3.7.4 already used in my tests.
-
Give it a try.
-
Give it a try.
I will but thas means people will not be able to update. Only new people will be able to use the refactored script.
-
But it will confirm the issue. I will fix it for sure. Currently working on my client work.
-
But it will confirm the issue. I will fix it for sure. Currently working on my client work.
Installed from scratch with no problems (created db etc etc).
THIS:
[09-Dec-2017 20:30:15 Europe/Madrid] PHP Notice: Array to string conversion in /home/oc-includes/osclass/helpers/hSanitize.php on line 183
remains as before.
As for the OsclassWizards error i will check later. Your installation is missing Bender theme folder files (only a folder is included), so i'm installing it.
-
An issue: Switching from bender to OsclassWizards theme, i see this:
[09-Dec-2017 20:36:37 Europe/Madrid] PHP Notice: Plugin osclasswizards is missing the index.php file /home/oc-content/plugins/osclasswizards/index.php in /home/oc-includes/osclass/classes/Plugins.php on line 124
The Osclasswizards is untouched and i REinstalled it from Market. And Index.php is not missing, it is there.
Well, on the virgin installation that error doesn't show. I have no idea why, but it doesn't.
-
Hey thanks for your hard work. I will check it as soon as I get sometime.
Regards
-
Hey thanks for your hard work. I will check it as soon as I get sometime.
Regards
Actually it is YOUR hard work not mine.
::)
-
Thanks, really appreciated.
-
Thanks, really appreciated.
But he is just a damn spammer, he just copied in full my first reply to you:
https://forums.osclass.org/development/experimental-osclass-fork/msg158422/#msg158422
-
And he INSERTED a LINK into your quote !!!! to his site(s) !!!
Reported.
-
And he INSERTED a LINK into your quote !!!! to his site(s) !!!
Reported.
Ohh I didn't checked it.
-
And he INSERTED a LINK into your quote !!!! to his site(s) !!!
Reported.
Ohh I didn't checked it.
No problem, i emailed info @ Osclass about it, since it seems that the REPORT function of the forums doesn't reach a valid mailbox.
-
Hi,
Outstanding job, Navjot Tomer :)
I'm testing it and reviewing the code, so far so good.
Many thanks for this initiative, regards
-
it does sound like a good idea
1) there are a lot of libarys used in osclass that are outdated, but its going to be a big task to take on to update them
2) what about trying to get composer involved in handling updates of packages included in osclass
3) someone please fix the uk regions file as well ( united kingdom has been missing a whole country (wales) for years now )
4) creating a stock theme for osclass that is simply based around bootstrap would be a very good improvement in itself over the stock theme
-
3) someone please fix the uk regions file as well ( united kingdom has been missing a whole country (wales) for years now )
4) creating a stock theme for osclass that is simply based around bootstrap would be a very good improvement in itself over the stock theme
Those two have nothing to do with the topic we discuss.
For your (3) see:
https://forums.osclass.org/general-help/osclass-geo-databases/
and continue in there if you wish.
8)
-
Hi navjottomer,
I just saw this topic here and briefly looked at the work you've done. Awesome!
However, I have a friendly tip: split things. Don't do everything in one branch, because most probably it wan't all be accepted into dev, and later into master. Don't let few things stop the entire PR.
So, smaller things, like code realignment, refactoring, phpdoc, typos and similar stuff should go to => Osclass dev branch, directly. Also, it makes tracking issues/PRs more easily for everyone.
This way you'll save time and focus on important things in your version.
This is just my opinion, and also, to make it easier for the Osclass Team to review and accept your changes.
And, OT already announced few months earlier they will start removing things for the 4.0 version, but it is not so clear when that will happen, so...
Regards,
dev101
-
Hey, everyone was busy with my client work in last two week and forgot to track record of this thread.
First thanks everyone for encouragement and suggestions.
Hi navjottomer,
I just saw this topic here and briefly looked at the work you've done. Awesome!
...
And, OT already announced few months earlier they will start removing things for the 4.0 version, but it is not so clear when that will happen, so...
Regards,
dev101
I was thinking about that too, will split workflow to different branches in future.
it does sound like a good idea
1) there are a lot of libarys used in osclass that are outdated, but its going to be a big task to take on to update them
2) what about trying to get composer involved in handling updates of packages included in osclass
...
I have plan to use composer for library handling. For regions I think we need to create another repo for that and that is out of my scope as being a single person doing all the work. I also have a plan to include a new theme for osclass but that too in future.
Here are the goals:
Cleaning and Refactoring Code.
Updating Library.
Adding small new features.
Removing dependencies of plugins for few standard features.
Although goals are simple but need lots of time and I need every help to mitigate this issue.
Regards
-
Personally, I don't vote for Composer with Osclass, reason being quite simple: some libraries are customized to provide better/broader compatibility. It's not just possible to use blind latest version updates.
There are 2 attempts to integrate it, and both are kind of abandoned / incomplete.
Conejo also mentioned that Osclass will continue to provide all necessary libs as a standalone complete package, which is user friendly for most users.
Also, take a look at WordPress, same thing.
-
I agree with your concern. It is not my goal but in future if their is a possible way to offload external libraries to composer without sacrificing compatibility issue than it will be good. Anyway it is not in my need to do list. I have already mentioned my primary goal.
Regards
-
Any news on this ? I see you synced 3.7.5 ?
-
Any news on this ? Osclass needs a lot of work to be done