Osclass forums
Development => Development => Topic started by: nootkan on January 29, 2014, 03:52:53 am
-
I have a problem when using the payment plugin in combination with the osshaft_colors theme that I would like someone to resolve for me. This seems to be an issue with every theme except Bender, but I would like it to work with the osshaft_colors theme. Here is the problem: When I register with a dummy account and then login, I go to my account and click on the "listings for payment status" or "Buy credit for payments" links I get redirected to the default bender theme instead of my custom theme osshaft_colors. I have searched and posted in this forum but no one seems willing to help me with this voluntarily so I am willing to pay for the solution. I have done a lot of the ground work based on this post: http://forums.osclass.org/plugin-payments/payment-switching-from-modern-to-bender-and-back-again/ (http://forums.osclass.org/plugin-payments/payment-switching-from-modern-to-bender-and-back-again/)and finally got it to go to my custom pages, but the pages are not rendering properly and when I view the page source I see the closing head tag is missing among a few other things. I just cannot seem to figure this out. If you are an expert in php and if you're interested in working on this please pm me and I'll respond.
-
Actually I think we should be able to help you here though it might take a bit longer.
Do you have a link to your website to see what is being displayed?
Also, have you debugged your code using F12 in IE or using Firefox Firebug or something?
Regards,
Eric
-
@SmaRTeY, @nootkan
This bug is related to osc_add_route function problem. Thread here:
http://forums.osclass.org/plugins-20/payment-plugin-osc_add_route-bug/msg84095/#msg84095 (http://forums.osclass.org/plugins-20/payment-plugin-osc_add_route-bug/msg84095/#msg84095)
-
Thanks Frosti.
-
I respect your arguments Tom, it does take a lot of time sometimes to analyse a piece of code to get something as simple as two drop downs for a main and sub category select. (but I managed hehe)
Maybe a tip to speed things up when analysing, I use Windows GREP nowadays to search through ALL php and/or js scripts. Works like a charme and does save me lots of time when looking for something. There are for sure other alternatives that do the same but GREP seems to do the job and it is free. 8)
Rewriting the whole plugin might be what is needed but who am I to argue, I haven't made 1 plugin yet so I wouldn't know how difficult it is. ::)
Thanks,
Eric
-
Actually I think we should be able to help you here though it might take a bit longer.
Do you have a link to your website to see what is being displayed?
Also, have you debugged your code using F12 in IE or using Firefox Firebug or something?
Regards,
Eric
Eric, Here is the link to one of only two pages when logged out but it is still not rendering like the rest of the pages in the site.
http://www.nootkasoundclassifieds.com/payment/menu (http://www.nootkasoundclassifieds.com/payment/menu)
I have used firebug and opera's inspect element features but it still escapes me. Sorry I don't have anything to do with IE. I keep thinking it is something simple like a missing tag or something but I'm sure the frustration is clouding my train of thought.
-
@SmaRTeY, @nootkan
This bug is related to osc_add_route function problem. Thread here:
http://forums.osclass.org/plugins-20/payment-plugin-osc_add_route-bug/msg84095/#msg84095 (http://forums.osclass.org/plugins-20/payment-plugin-osc_add_route-bug/msg84095/#msg84095)
Thanks for the link to the thread, however it looks like it wasn't resolved either and php is not my strong point so I need some expert advice/help to get me through.
-
Yes. Frosti is on the right track.
It is an issue between the plugin and Osclass 3.x-up. That like many other plugins call for a file or code that does not exist so defaults to the GUI theme.
To attempt to make all themes workable with this and all other plugins calling for all these files would be near impossible.
The only real solution is to re-write the plugins.... Not really practical ether.
I been looking at the possibility of modifying the needed bender files for use in other themes but bender has it's code scattered in many files so it is very time/labor intensive to "create a file containing all the pieces needed. This is far above my abilities and time.
Tom
Tom, thanks for staying in tune with this issue. Hopefully _Conejo will revamp the plugin to be compatible with the new version.
-
Hi nootkan,
I do get a script error but that doesn't have to be the issue, however to be sure could you see what happens if you comment out the following code regarding the rendering? If there's no difference you can undo the comment again.
<!-- requrire location -->
<script type="text/javascript">
$(document).ready(function() {
if( $("form[name=item]").length > 0 ) {
$('input[id="region"]').addClass("{required: true, messages: { required: 'Region is required'}}") ;
$('input[id="city"]').addClass("{required: true, messages: { required: 'City is required'}}") ;
}
}) ;
</script>
-
Eric, I don't see the javascript in the functions.php file or the user-custom.php file which are the two files that I had to modify to get to the point where I am at now. That error must be in another file. I'll look around to see if I can find it.
I've attached the two files that I had to modify according to _Conejo's post here:
http://forums.osclass.org/plugin-payments/payment-switching-from-modern-to-bender-and-back-again/ (http://forums.osclass.org/plugin-payments/payment-switching-from-modern-to-bender-and-back-again/)
Update: don't use these two files as they are wrong. See the last post in this thread for the answer.
-
@SmaRTeY
Problem is not with plugin, but 1 new function:
osc_add_route('payment-user-pack', 'payment/pack', 'payment/pack', osc_plugin_folder(__FILE__).'user/pack.php', true);
above code does not work on modern theme, only bender, but:
osc_add_route('payment-user-pack', 'payment/pack', 'payment/pack', osc_plugin_folder(__FILE__).'user/pack.php');
works ok, but you do not get user menu and user header.
Works ok on bender (both codes).
I do not know, maybe way how to force users do not use other theme than bender. :o
-
Hi, I see Frosti,
seems to me that the function call is the only thing that is different (no true at the end). That would suggest that the function is different in Bender theme from the os-shaft theme. Should look better at the differences because if the code works well in Bender it should just work in any other theme as well unless things are different.
Now all the plugin code will be the same I think so what is left to check is the functions that come with both themes and specifically look at the the function where Frosti finds the differences in behaviour. Take it from there... is my guess
Regards,
Eric
-
@SmaRTeY
I got it solved:
http://forums.osclass.org/plugins-20/payment-plugin-osc_add_route-bug/msg84086/#msg84086 (http://forums.osclass.org/plugins-20/payment-plugin-osc_add_route-bug/msg84086/#msg84086)
Problem is that older themes do not include user-custom.php file that needs to be created ;)
-
Hehe see, it wasn't that hard ;)
Great find Frosti, a working plugin again and now I would really want the plugin to be updated so all files needed are there! (Sigh)
I would even go as far as doing a complete check on all the different themes and their added functions and bundle them with the default Bender since they are sometimes extra helpers or just value added functions to use with OsClass.
:)
-
@SmaRTeY
Plugins are ok, theme needs update.
-
@SmaRTeY
I got it solved:
http://forums.osclass.org/plugins-20/payment-plugin-osc_add_route-bug/msg84086/#msg84086 (http://forums.osclass.org/plugins-20/payment-plugin-osc_add_route-bug/msg84086/#msg84086)
Problem is that older themes do not include user-custom.php file that needs to be created ;)
Frosticek, that is what I have done, created a user-custom.php file and added the necessary functions to the functions.php file under "New Functions". But the pages are still not rendering properly. Because I am not fluent in php I was assuming that it may be something I've copied over from the bender theme functions.php file which is why I attached the two files for all to look over for me. Did you create the user-custom.php file and it works fine for you? If so, which theme? Could you attach your files so I can compare?
-
@nootkan
You do not need to create any functions in function.php, only that file.
-
That won't work either. When I first started to figure this out I copied the Bender Theme user-custom.php file without adding the body_class functions to the functions.php file but I got a body_class function error. After adding the functions I arrived at where I am now. I get the page to look like the rest of my theme but the divs aren't where they're supposed to be and there is a "A" character just above the header widget.
I tried to remove all the functions and also the php call to the body_class function in user-custom.php but I still get the same look for some reason. It looks the same way for both modifications (with or without the functions and call) in all browsers. I've attached a screenshot.
(http://www.nootkasoundclassifieds.com/oc-content/themes/nootka_colors/images/ScreenHunter_01-Jan.jpg)
-
Could it be a simple utf8 code failure? ::)
-
Maybe, I have no idea how to find out if it is or how to fix it. As I've stated previously I have very little php experience which hinders my ability to resolve this issue I am having with the user-custom.php file. That is why I wanted to pay someone to do this for me. Surely there is a way to trouble shoot this problem and resolve it? I have installed four other responsive themes and made no theme modifications and then created the user-custom.php file and all four themes provide the same result, an ugly payment/menu page that doesn't render properly. Yet every other facet of osclass using different themes works fine on my server it seems.
-
Sorry Nootkan, I thought there were others using PayPal and Bender without the div issues thinking we could get it solved here in the forums. I am out of ideas and hope there are others still who can help you.
Regards,
Eric
-
Eric, thanks for trying. I appreciate all you have done to try and help me with this issue. I too was sure that someone must be using the payment plugin with a custom theme experiencing the same issue. I find it hard to believe that no one has come up with a solution for this yet.
-
Why is this line in the actual page code or why not the correct space " ". What is that "A".
<p style="text-align: center;">Â </p>
is the entity used to represent a non-breaking space. It is essentially a standard space, the primary difference being that a browser should not break (or wrap) a line of text at the point that this occupies.
Many WYSIWYG HTML editors insert these entities in an effort to control the layout of the HTML document. For example, such an editor may use a series of non-breaking spaces to indent a paragraph like this:
<P>
This first line of text is supposed to be indented. However, many browsers will not render it as intended.
</P>
As the example mentions, some browsers will not, in fact, indent the text because of how that particular browser handles the entity. Some browsers collapse multiple, concurrent non-breaking spaces into a single space. This sometimes happens, even if there are regular spaces separating the consecutive entities. So keep in mind that this "technique" can not be relied on.
There are some times when it is "acceptable" or "advisable" to use the entity so long as the consequences are understood:
Its intended use of creating a space between words or elements that should not be broken. The only problems that can be associated with this use is that too many words strung together with non-breaking spaces may require some graphical browsers to show horizontal scrollbars or cause them to display the text overlapping table borders.
If you need to have an empty table cell, it is often advised that you add a non-breaking space like <TD> </TD>. This is because some versions of IE seem to have problems with completely empty table cells.
Indentation. It is generally discouraged to use a non-breaking space, or a series of non-breaking spaces to "force" an indentation. This practice is discouraged for two primary reasons. First, not all browsers handle the entity properly and may in fact ignore it when rendering the document. Second, the practice of trying to "force" a specific presentation is often frowned upon as it tends to fail and/or makes it more difficult for some readers whose browsers may be configured differently from your own.
Just thought I would fill this gray space...... ;D :P
Tom
-
Tom, I removed the code you referenced from the html header widget and that got rid of the special character so you were right about the wysiwyg text editor and spaces. I also notice some characters next to the text in the header and footer widget admin section (see the image). Will look at why that is occurring at a later date.
(http://www.nootkasoundclassifieds.com/oc-content/themes/nootka_colors/images/ScreenHunter_01-Feb.jpg)
I noticed that the doc type is missing from the osshaft_colors header.php file so I added the same one from the bender theme but that didn't make a difference either.
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml" dir="ltr" lang="en-US">
-
Tom, I think I figured it out. None of your css for theme osshaft_colors is being inherited by the payment/menu or payment/pack pages even though the elements have the same name as the other pages in the theme.
-
Wahoo, I figured it out. It was definately a styling issue. For anyone else who is trying to do this you must include the following inside your header.php file for the osshaft_colors theme.
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" dir="ltr" lang="<?php echo str_replace('_', '-', osc_current_user_locale()); ?>">
<head>
<?php osc_current_web_theme_path('head.php'); ?>
<meta name="robots" content="index, follow" />
<meta name="googlebot" content="index, follow" />
</head>
<!-- container -->
and this is what is inside my user-custom.php file:
<?php
/*
* Osclass – software for creating and publishing online classified
* advertising platforms
*
* Copyright (C) 2013 OSCLASS
*
* This program is free software: you can redistribute it and/or
* modify it under the terms of the GNU Affero General Public License
* as published by the Free Software Foundation, either version 3 of
* the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful, but
* WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public
* License along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
osc_current_web_theme_path('header.php') ;
osc_render_file();
osc_current_web_theme_path('footer.php');
?>
This seems to work just fine for me now. Whew what a drawn out process for something I should have thought of first and foremost. Thanks to all who provided me with direction and support. Much appreciated! ;D
-
Tom, I think I figured it out. None of your css for theme osshaft_colors is being inherited by the payment/menu or payment/pack pages even though the elements have the same name as the other pages in the theme.
Or,
The plugin was/is not drawing from the theme styling.... If the plugin does not have or is designed to use the theme css then the plugin must be looking in the wrong place or looking for wrong named css file. If that is the case then what happens with all the themes that use varying named css files. bender being "main". Others 'style", styles", etc. osshaft_colors uses a few different named css files depending on the choice made in admin.
The plugin dev knew when created that the plugin "needs" certain files coded in certain ways to work proper. Why would that dev "assume" that a theme or for that matter a core script would or even should be designed and scripted for HIS plugin.
Interesting that page after page concerning plugin issues are filled with "payment" type plugin problems with no clear indications that the problems are core or theme related or caused...... yet we keep modifying core and themes trying to accommodate or overcome these plugin problems.
So we are back to the problem of no real, concrete parameters for plugins to follow......
When/ if everything works as intended the doc type should only have to be declared once in the head file unless an individual page has a special need.
The user-custom is just a generic page similar to others so really should not have to be modified for any one plugin.
Just my view on the world which I admit is from a much different angle..... :o
Happy you got it resolved... ;D and impressed you stuck with this plugin issue to a successful conclusion.
Tom
-
Also glad you got it solved Nootkan!
you must include the following inside your header.php file for the osshaft_colors theme
Tom, isn't head.php 'always' needed in page creation within OsClass?
Declarations/registrations are done in head.php as well as some other basic stuff needed to display a correct OsClass page but maybe the page is setup in another way in that theme?
The issue was the missing head.php I think that actually sets the filepaths to CSS and others. Meaning, plugins without their own CSS will default to the default OsClass CSS but then in their page setup the header.php must include the head.php.
Structure of page setup:
head =>
header (widget(s)) =>
page
footer (widget(s)) =>
As far as the 'wrong' codes, if you used an editor with the wrong characterset chances are you will Always end up with 'wrong' output even though everything looks normal. Always use a decent editor like Notepad++ and Always make sure you are using the right characterset/codepage = UTF8.
Regards,
Eric
-
Also glad you got it solved Nootkan!
you must include the following inside your header.php file for the osshaft_colors theme
Tom, isn't head.php 'always' needed in page creation within OsClass?
Declarations/registrations are done in head.php as well as some other basic stuff needed to display a correct OsClass page but maybe the page is setup in another way in that theme?
The issue was the missing head.php I think that actually sets the filepaths to CSS and others. Meaning, plugins without their own CSS will default to the default OsClass CSS but then in their page setup the header.php must include the head.php.
Structure of page setup:
head =>
header (widget(s)) =>
page
footer (widget(s)) =>
As far as the 'wrong' codes, if you used an editor with the wrong characterset chances are you will Always end up with 'wrong' output even though everything looks normal. Always use a decent editor like Notepad++ and Always make sure you are using the right characterset/codepage = UTF8.
Regards,
Eric
Perhaps this is a misunderstanding of what I was trying to say.....
Yes, of course to your head comments.
Only editor I use is notepad++ set to utf8. Have a couple others installed but haven't used them in along time.
-
I guess I spoke too soon. It seems that after fixing my issue with the payment plugin and the user-custom.php file to render my payment/menu page properly, placing the
<?php osc_current_web_theme_path('head.php'); ?> inside the header.php file is now making my login dropdown in the header of the site to drop and close immediately. What is happening I believe is that my head content between the <head> tags is being duplicated. There has to be a way to make this work.
-
Okay I believe I have it resolved now. I removed the
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" dir="ltr" lang="<?php echo str_replace('_', '-', osc_current_user_locale()); ?>">
<head>
<?php osc_current_web_theme_path('head.php'); ?>
<meta name="robots" content="index, follow" />
<meta name="googlebot" content="index, follow" />
</head>
from the header.php file and placed
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" dir="ltr" lang="<?php echo str_replace('_', '-', osc_current_user_locale()); ?>">
osc_current_web_theme_path('head.php');
inside the user-custom.php file and it seems to function fine now.
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" dir="ltr" lang="<?php echo str_replace('_', '-', osc_current_user_locale()); ?>">
<?php
/*
* Osclass – software for creating and publishing online classified
* advertising platforms
*
* Copyright (C) 2013 OSCLASS
*
* This program is free software: you can redistribute it and/or
* modify it under the terms of the GNU Affero General Public License
* as published by the Free Software Foundation, either version 3 of
* the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful, but
* WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public
* License along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
osc_current_web_theme_path('head.php');
osc_current_web_theme_path('header.php') ;
osc_render_file();
osc_current_web_theme_path('footer.php');
?>
The only thing I see wrong is that the <head> tags are missing when viewing page source for payment/menu.
-
:o
Sorry Tom, wasn't trying to tell you.... was merely looking for confirmation. :)
@nootkan, to be honest I really think the head reference should go inside header but if it works it works.
-
:o
Sorry Tom, wasn't trying to tell you.... was merely looking for confirmation. :)
@nootkan, to be honest I really think the head reference should go inside header but if it works it works.
Thought the same. Seems strange to have it like that but..... whatever it takes.
Tom
-
Hi guys, unfortunately it wouldn't work properly for me in the header.php. It was causing issues with the dropdown login feature in the header. Also I noticed duplicate head content when viewing the page source which was probably causing the login script to fail. As soon as I removed the php head call from the header file the login issue disappeared. When I placed the call in the user-custom.php file the login worked and the payment/menu page rendered properly. As I stated the only issue I see now is no <head> tags surrounding the head content in the user-custom.php page when viewing the page source. Probably a way to include it using php but I cannot figure it out.
-
I see nootkan but the whole setup is based on head in header, at least in my setup using minimalist or bender 1.1.0.
Here's how bender header.php is setup:
<html xmlns="http://www.w3.org/1999/xhtml" dir="ltr" lang="<?php echo str_replace('_', '-', osc_current_user_locale()); ?>">
<head>
<?php osc_current_web_theme_path('common/head.php') ; ?>
</head>
<body <?php bender_body_class(); ?>>
When you put head in your header I can see issues maybe happening if you have in header a declaration/registration of some script that also is being registered in head.php ? ::)
-
This is the set up for osshaft_colors header.php so you can see it is a little different. Doesn't matter I have that part working now.
<?php
/*
* Osclass – software for creating and publishing online classified
* advertising platforms
*
* Copyright (C) 2012 OSCLASS
*
* This program is free software: you can redistribute it and/or
* modify it under the terms of the GNU Affero General Public License
* as published by the Free Software Foundation, either version 3 of
* the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful, but
* WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public
* License along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
?>
<!-- container -->
<div class="container">
<!-- header -->
<div id="header">
-
For those working with Modern, I was able to fix the problem as follows without having to touch header.php.
Here's what I did:
1. Make a local copy of user-alerts.php from your Modern theme folder
2. Rename your local copy of user-alerts.php to user-custom.php
3. Find <div id="main"> in the file
4. Remove everything below it up to the second last </div>
5. Paste <?php osc_render_file(); ?> between <div id="main"> and the second last </div>
6. Save and upload to the Modern theme folder.
The main section is <?php osc_render_file(); ?>, everything else is the template settings around it so I figured I could use any of the main user php files and simply replace the main section with <?php osc_render_file(); ?>. It appears to have worked. If anyone believes there might be a problem with this, please let us know. I compared a couple of user php files and the main sections only appear to differ.
-
For modern theme, this one should work like a charm:
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" dir="ltr" lang="<?php echo str_replace('_', '-', osc_current_user_locale()); ?>">
<head>
<?php osc_current_web_theme_path('head.php') ; ?>
<meta name="robots" content="noindex, nofollow" />
<meta name="googlebot" content="noindex, nofollow" />
</head>
<body>
<?php osc_current_web_theme_path('header.php') ; ?>
<div class="content user_account">
<h1>
<span><?php _e('User account manager', 'sofia') ; ?></span>
</h1>
<div id="sidebar">
<?php echo osc_private_user_menu() ; ?>
</div>
<div id="main" class="ad_list">
<?php osc_render_file(); ?>
</div>
</div>
<?php osc_current_web_theme_path('footer.php') ; ?>
</body>
</html>