Speedup Translation

[Ranman]

Hi,

i found a small performance issue in OsClass.
It would be great if someone can change the source in the repository.

I change the code from this:

Code: [Select]

  /**
     * Translate strings
     *
     * @since unknown
     *
     * @param string $key
     * @param string $domain
     * @return string
     */
    function __($key, $domain = 'core') {
        $gt = Translation::newInstance()->_get($domain);

        if(!$gt) {
            return $key;
        }
        $string = $gt->translate($key);
        return osc_apply_filter('gettext', $string);
    }


To this, and i was able to speed up my index page by up to 30%

Code: [Select]

/**
     * Translate strings
     *
     * @since unknown
     *
     * @param string $key
     * @param string $domain
     * @return string
     */

    function __($key, $domain = 'core') {
        if(!$gt) {
            return $key;
        }               
       
        if($GLOBALS['__translations'][$domain][$key] == null)
        {
            $string = $gt->translate($key);
            $GLOBALS['__translations'][$domain][$key] = osc_apply_filter('gettext', $string);           
        }
       
        return $GLOBALS['__translations'][$domain][$key]  ;
    }



[teseo]

Hi,

Well, with that modification you're effectively disabling every translation using function __(). Fine if you're using english only, but a problem otherwise. Maybe an option to do that (disable all translations, not only those who use that function) on the Admin Dashboard would be a reasonable request.

Regards

[Ranman]

aah... damn... i should go to bed... yes you are totally right