IMPORTANT - How to Have a really funcional Search

[teseo]

Yup, this worked flawlessly up to Osclass 3.4.2 but something must have changed in latest version (hopefully for the best, we'll see)

I'll study this tomorrow, regards.

[darmeth]

Thanks for all your help Teseo

[brenosilver]

On v3.4.3 doesn't work =(

Looking at the commit history https://github.com/osclass/Osclass/commit/a5bf12853eca96331ddb3160eb24a6db6a888495 They did change oc-includes/osclass/controller/search.php

[darmeth]

 
I've been trying to read more about searching MySQL ...it is a very tough nut to crack! The reason I have seen over and over is because too many wildcards plus too many rows in the tables can make the search and server slow down a lot.

I think I will put this one to sleep now and perhaps revisit it in the future when the traffic and listings pickup. It seems that the best solution is to have a separate table that is used to index the search terms and every search will query only that table.

[teseo]

***CORRECTED***

Hi,

Sorry for the delay, but my computer had a major accident,  still recovering, but I'm back...

In the end this was no big issue, just tested this on latest Osclass 3.5.3.

Add this at the very bottom of your theme functions.php (take care not to leave blank lines after this):

Code: [Select]

<?php
function cust_search_keyword_wildcard($params) {

    if (@$params['sPattern']) {
        $mSearch =  Search::newInstance();
        $query_elements = (array) json_decode($mSearch->toJson());
    
        $query_elements['sPattern'] = str_replace(' ', '* ', $query_elements['sPattern']) . '*';
    
        $mSearch->setJsonAlert($query_elements);
    }
}

osc_add_hook('search_conditions', 'cust_search_keyword_wildcard', 10);  
?>

Regards

[Adyyda]

Hi,

Sorry for the delay, but my computer had a major accident,  still recovering, but I'm back...

In the end this was no big issue, just tested this on latest Osclass 3.5.3.

Add this at the very bottom of your theme functions.php (take care not to leave blank lines after this):

Code: [Select]

<?php
function cust_search_keyword_wildcard($params) {

    if ($params['sPattern']) {
        $mSearch =  Search::newInstance();
        $query_elements = (array) json_decode($mSearch->toJson());
    
        $query_elements['sPattern'] = str_replace(' ', '* ', $query_elements['sPattern']) . '*';
    
        $mSearch->setJsonAlert($query_elements);
    }
}

osc_add_hook('search_conditions', 'cust_search_keyword_wildcard');  
?>

Regards

Can you tune it up a little?
Word "Apple"
If i search for "apple" works ok with your fix.
If i search for "pple", no results - so can you fix this as well? Thanks

[teseo]

Not possible, regards

[Adyyda]

Not possible, regards

OK

[darmeth]

@teseo - sorry for the delay in replying. I have just added this and tested and it works 100%. Many thanks again for your help.

[ricardiinhu]

hey teseo, thank you!! i had this problem too and the solution you gave works fine!!
thanks a lot!!

[teseo]

You're welcome. Regards.

[tims]

Hello teseo. I don't know if this is right to ask this question in this tread but do you know how to add the user/contact name to the search? I search already the how forum and ask it so many times but no one can answer it or demo how to do it. Kindly help us. Thank you

[teseo]

Hi,

Do you want that to add it to the method described on this thread or should it work with default search?

Regards

[tims]

If possible to the search of this thread. If not even in default will do. Thank you very much

[teseo]

Well, first I have to warn you that this will be expensive in terms of time, because it adds to the normal query (made over a table built for that -t_description) a search over t_item table that it's not optimized for that kind on use. If there are many search terms, each one must be processed independently. So, I wouldn't recommend this unless you don't have a lot of ads or your server is rather powerful.

Anyway, here it is:

Add this at the very bottom of your theme functions.php (take care not to leave blank lines after this):

Code: [Select]

<?php
function cust_search_keyword_wildcard_with_username($params) {

    if ($params['sPattern']) {
        $mSearch =  Search::newInstance();
        $query_elements = (array) json_decode($mSearch->toJson());
        $pattern = $query_elements['sPattern'];


        $query_elements['sPattern'] = str_replace(' ', '* ', $pattern) . '*';

        $mSearch->setJsonAlert($query_elements);

        // Search by Username too
        $aPattern = explode(' ', $pattern);
        $userNameCond = '';

        foreach ($aPattern as $word) {
            if ($word) $userNameCond .= sprintf(" || %st_item.s_contact_name LIKE '%s%%'", DB_TABLE_PREFIX, $word);
        }

        $mSearch->addConditions("1 = 1 " . $userNameCond);
        $mSearch->addGroupBy(DB_TABLE_PREFIX.'t_item.pk_i_id'); 
    }
}

osc_add_hook('search_conditions', 'cust_search_keyword_wildcard_with_username', 1); 
?>

Regards