[PLUGIN] Motorcycles attributes Ver. 1.2.2 Update: Sept. 11, 2013

[mortaza2006]

hi mmcsus

Sorry I can't speak good English

Known problems:

1. Can not delete makes and models from admin (This problem existed in cars attributes plugin.)

Please check it it out and let me know what can make it better.

To fix this problem
You do

open file conf.php

and changes this lines

Code: [Select]

                                                        echo '<li><input name="make[' . $make['pk_i_id'] . ']" id="' . $make['pk_i_id'] . '" type="text" value="' . $make['s_name'] . '" /> <a href="' . osc_admin_base_url(true) . '?page=plugins&action=renderplugin&file=motorcycles_attributes/conf.php?section=makes&plugin_action=make_delete&id=' . $make['pk_i_id'] . '" ><button class="benderbtn">' . __('Delete', 'motorcycles_attributes') . '</button></a> </li>';   

to

Code: [Select]

                                                        echo '<li><input name="make[' . $make['pk_i_id'] . ']" id="' . $make['pk_i_id'] . '" type="text" value="' . $make['s_name'] . '" /> <a class="benderbtn" href="' . osc_admin_base_url(true) . '?page=plugins&action=renderplugin&file=motorcycles_attributes/conf.php?section=makes&plugin_action=make_delete&id=' . $make['pk_i_id'] . '" >' . __('Delete', 'motorcycles_attributes') . '</a> </li>';


in fact
delete <button> in codes

Code: [Select]

<button class="benderbtn">' . __('Delete', 'motorcycles_attributes') . '</button>

Change your

Code: [Select]

' . __('Delete', 'motorcycles_attributes') . '


[mmcsus]

Hi mortaza2006,

Thanks

https://github.com/osclass/osclass-plugins/pull/153/files#diff-0

[Aficionado]

The above bug fix from Mortaza solves the delete in Car Makes and Car Model Types.

But the 3rd option (Vehicle Type) still has the delete problem.

[mmcsus]

Motorcycles Attributes

Author: mmcsus_Osclass

version 1.1
Update:
Motorcycles attributes

Version 1.1

Changes:

1. Corrected "Makes" delete function.

2. Corrected "Models" delete function.

3. Corrected "Motorcycle types" delete function.

4. Changed vehicle types in admin to Motorcycle types.

5. Changed style of "Edit button".

6. Kept style of delete button for Makes, Models, and Motorcycle types by using span tag.

Reference:

https://github.com/faosclass/osclass-plugins/commit/af70b0b718a2513506b8a429bc62d1089a58ab5c

Download from first post.

[mmcsus]

@potoco

Both plugins left four tables into database, then I delete them manually....

I would like to run a little experiment, if your willing?

Find attached potocos_attributes plugin.

This is nothing more than motorcycles_attributes just without the name.

I would like for you to install it on your system and tell me if it works.

I have checked to make sure when you uninstall it the tables will be removed from mysql.

[Aficionado]

Apparently something IS wrong with uninstall. Because i can't install the 1.1 after uninstalling the plugin.

And i see 4 tables in the db that i had to manually delete ..

just FYI,

[Aficionado]

I also see that there is a limit of 10 Vehicle types (as with car plugin) and that is a problem for localized osclass installations.

For one language 10 is ok, for two languages it is not.

(still i can't find any 10 items limitation in the code ....)

[mmcsus]

Hi Aficionado,

Sorry for the late reply.

(still i can't find any 10 items limitation in the code ....)

There is no limitation in the code.

The problem is once  motorcycle types gets to 10  mysql starts over and you git DUPLICATE KEY errors.

So now you know the issue, I'am not a mysql Guru but I thought I was. 

We all have a lot to learn.

Isn't that's what it's all about?

[Aficionado]

Hi Aficionado,

Sorry for the late reply.

(still i can't find any 10 items limitation in the code ....)

There is no limitation in the code.

The problem is once  motorcycle types gets to 10  mysql starts over and you git DUPLICATE KEY errors.

So now you know the issue, I'am not a mysql Guru but I thought I was. 

We all have a lot to learn.

Isn't that's what it's all about?

Hi there !

You mean this is a bug of the Car Attributes plugin ? Why start over after 10 ?

You see i'm neither a mysql or php expert ...
 

[Aficionado]

Plugin could not be installed because: Error importSQL::Modelmotorcycles
motorcycles_attributes/basic_data.sql

ok, i found the problem with install (after uninstall) fails.

If you DISABLE the plugin and THEN uninstall, some tables are left and you can't install it again.

If you UNINSTALL the plugin while ENABLED everything is cleared.

Not sure why this happens. With Cars also.

[potoco]

@potoco

Both plugins left four tables into database, then I delete them manually....

I would like to run a little experiment, if your willing?

Find attached potocos_attributes plugin.

This is nothing more than motorcycles_attributes just without the name.

I would like for you to install it on your system and tell me if it works.

I have checked to make sure when you uninstall it the tables will be removed from mysql.

Hi mmcsus, this plugin has failed, sorry, I don't find the option to switch on the php debug so I don't know what to do to switch it. I am on an vserver, will be the reason?

I had to delete the four tables in the database again...

[mmcsus]

I had to delete the four tables in the database again...

Hi potoco,

I am on an vserver

Pardon my ignorance but what is a vserver?

I do not have these problems. I would like to understand what's going on.

I'm on a VPS server. (Unmanaged)

I would like to set up an account for you on my server. ( for testing only of course)

Let me see what I can do ...

[mmcsus]

I would like to set up an account for you on my server. ( for testing only of course)

Let me see what I can do ...

... done!

[potoco]

Pardon my ignorance but what is a vserver?

The vserver is an virtual server, shared server, maybe something like yours, don't worry about it, I have a phisycal server too, so when I can I will move an OSClass installation in order to make more test. I don't have time this week so we keep in touch.

Thank you so much for your concern.

[Hostingames]

hi
the plugin t there before I install bug

thank you