SOLVED I'm getting php notices in my log files

[marius-ciclistu]

PHP Notice:  Undefined index: fk_i_category_id in /oc-includes/osclass/helpers/hDefines.php on line 487
PHP Notice:  Undefined index: pk_i_id in /oc-includes/osclass/helpers/hDefines.php on line 493
PHP Notice:  Undefined index: s_city in /oc-includes/osclass/helpers/hDefines.php on line 494
PHP Notice:  Undefined index: s_title in /oc-includes/osclass/helpers/hDefines.php on line 495

How to define them?

Code: [Select]

    /**
     * Create item url from item data without exported to view.
     *
     * @since 3.3
     * @param array $item
     * @param string $locale
     * @return string
     */
    function osc_item_url_from_item($item, $locale = '')
    {
        if ( osc_rewrite_enabled() ) {
            $url = osc_get_preference('rewrite_item_url');
            if( preg_match('|{CATEGORIES}|', $url) ) {
                $sanitized_categories = array();
487:                $cat = Category::newInstance()->hierarchy($item['fk_i_category_id']);
                for ($i = (count($cat)); $i > 0; $i--) {
                    $sanitized_categories[] = $cat[$i - 1]['s_slug'];
                }
                $url = str_replace('{CATEGORIES}', implode("/", $sanitized_categories), $url);
            }
493            $url = str_replace('{ITEM_ID}', osc_sanitizeString($item['pk_i_id']), $url);
494            $url = str_replace('{ITEM_CITY}', osc_sanitizeString($item['s_city']), $url);
495            $url = str_replace('{ITEM_TITLE}', osc_sanitizeString($item['s_title']), $url);
            $url = str_replace('?', '', $url);
            if($locale!='') {
                $path = osc_base_url().$locale."/".$url;
            } else {
                $path = osc_base_url().$url;
            }
        } else {
            $path = osc_item_url_ns($item['pk_i_id'], $locale);
        }
        return $path;
    }


[Web-Media]

How and where do you use the function ?
Not the function itself is the problem , but the way is used .

[marius-ciclistu]

I didn't changed the way osclass uses it in 3.7.1

[Liath]

it could be theme or plugin related

[marius-ciclistu]

it could be theme or plugin related

I don't use plugins, so it's theme related... but I don't undertand why..those variables are from the table-database..and the function gives the url of the item, so it works fine.

[Liath]

maybe there are some empty variables delivered to this functions


you have to look where are this functions are called and why this vars are empty, but... this are just (mostly) harmless notices... you could ignore them

[marius-ciclistu]

Maybe you are right but I noticed that the 4 table columns are from

oc_t_item
  - pk_i_id
  - fk_i_category_id
oc_t_item_description
   - s_title
oc_t_item_location
  - s_city

Does this mean anything?

[Liath]

of course... that means, that the affected file could be item.php 

[marius-ciclistu]

Ok. The only thing is that these lines in log files are using space on server . I had 240mb log file because I forgot to declare all the items of an array for a map hovering functionality that shoes the number of ads in a region (the regions with 0 ads gave the undefined warnings).
So if the site is visited by many people the log fills up ( even with notices).

[SmaRTeY]

It's best to trap empty/''/null/isset/is_array values and handle them accordingly.

[marius-ciclistu]

Not shure what you mean by that (I mean the actual code that does that), but this is related to the osclass 3.7.1 files, not to my modifications, so if I have them. someone else should have them. I don't know if in 3.7.3 they are still pressent.

[SmaRTeY]

That is correct, Osclass does have 'some' undefined notices, they are harmless but should really be taken care of in core code.
However, if you made changes in core than it IS possible these notices are related to those changes as well.

I think in 3.7.3 there still are similar notices in package.

[marius-ciclistu]

I doubt my mods generated these notices.

[SmaRTeY]

Well you can simply add your own handling to get rid of these notices.

For instance on line 487 of hDefines you can add something like this:
If( isset(fk_i_category_id) ) {
.....
} else {
.....
}

[marius-ciclistu]

But if we think about it....this function should construct the url.
Why is(should) this function called(be called) with a "half" item array?

It's description:  Create item url from item data without exported to view.

That "without exported to view" may be the reason for these notices?