Experimental Osclass fork

[navjottomer]

Removing legacy code means Updating libraries using php4 era syntax. Using modern php5 functions. It is work in progress so I can't comment on what we remove and what we include. I just need help and suggestions right now. It will we morr clear when we achieve our first goal.
Regards
Navjot

[marius-ciclistu]

Thank you. I thought that refactoring old code meant that you update the code acc to newer php versions. Thank you for clarifying.

[Aficionado]

I don't see much interest. Anyway.

Just finished backup my online dev installation (home dir AND Database). I will upload the updated files from Github in a while and see how it goes.

I will update here with a summary asap.

[Aficionado]

I don't see option to create an Issue at Github, so ...

After playing a bit with the experiment version and Bender, i only see a lot of this Notice:

[09-Dec-2017 20:30:15 Europe/Madrid] PHP Notice:  Array to string conversion in /home/oc-includes/osclass/helpers/hSanitize.php on line 183

[Aficionado]

An issue: Switching from bender to OsclassWizards theme, i see this:

[09-Dec-2017 20:36:37 Europe/Madrid] PHP Notice:  Plugin osclasswizards is missing the index.php file /home/oc-content/plugins/osclasswizards/index.php in /home/oc-includes/osclass/classes/Plugins.php on line 124

The Osclasswizards is untouched and i REinstalled it from Market. And Index.php is not missing, it is there.

[navjottomer]

Thanks I will work it. What version of php you are using?

[Aficionado]

Thanks I will work it. What version of php you are using?

I'm using PHP 7.0.26

[Aficionado]

Thanks I will work it. What version of php you are using?

Also allow Issues to github if you want reports in there.

[navjottomer]

Thanks I will work it. What version of php you are using?

Also allow Issues to github if you want reports in there.

Oops I forget that, enabled now.

[navjottomer]

Ok I try to reproduce error on both php5.6 and php7.1 and didn't get any error. I tested it on default installation(no other plugin only stock, with one example ad) with bender theme, can't comment on osclasswizards as I don't have it.
More info will be needed to resolve it. I have enabled issues on github, so we can discuss it their.
Regards

[Aficionado]

OsclassWizards is free, you can get it and test it.

As for the rest, i also have no plugins installed but i run 7.0 and not 7.1.

[Aficionado]

Should i start with a clean db ?

Because i didn't. I used the 3.7.4 already used in my tests.

[navjottomer]

Give it a try.

[Aficionado]

Give it a try.

I will but thas means people will not be able to update. Only new people will be able to use the refactored script.

[navjottomer]

But it will confirm the issue. I will fix it for sure. Currently working on my client work.