Osclass forums
Development => Development => Topic started by: byteGator on June 12, 2013, 01:36:56 pm
-
It will remove whitespace and crop 1/2 on width or 1/4 top & 3/4 bottom on height.
In ImageResizer.php use this calculation.
$w = imagesx($this->im);
$h = imagesy($this->im);
$newW = ($w > $width)? $width : $w;
$newH = ($h > $height)? $height : $h;
if(($w/$h)<($width/$height)) {
//$newW = $width;
$cropedW = $w;
$cropedH = ($w > $width)? ($w * $height / $width) : $newH;
$offsetx = 0;
$offsety = ($h - $cropedH) / 4;
} else {
//$newH = $height;
$cropedW = ($h > $height)? ($h * $width / $height) : $newW;
$cropedH = $h;
$offsetx = ($w - $cropedW) /2;
$offsety = 0;
}
$newIm = imagecreatetruecolor($width,$height);//$newW, $newH);
imagealphablending($newIm, false);
$colorTransparent = imagecolorallocatealpha($newIm, 255, 255, 255, 127);
imagefill($newIm, 0, 0, $colorTransparent);
imagesavealpha($newIm, true);
imagecopyresampled($newIm, $this->im, (($width-$newW)/2), (($height-$newH)/2), $offsetx, $offsety, $newW, $newH, $cropedW, $cropedH);
imagedestroy($this->im);
$this->im = $newIm;
In ItemActions.php
Change
ImageResizer::fromFile($normal_path)->resizeTo($size[0], $size[1])->saveToFile($path);
TO
ImageResizer::fromFile($tmpName)->resizeTo($size[0], $size[1])->saveToFile($path);
twice.
And you can adjust your image/thumbnail size in oc-admin page.
-
is this the replacement or what we have to replace??
$w = imagesx($this->im);
$h = imagesy($this->im);
$newW = ($w > $width)? $width : $w;
$newH = ($h > $height)? $height : $h;
if(($w/$h)<($width/$height)) {
//$newW = $width;
$cropedW = $w;
$cropedH = ($w > $width)? ($w * $height / $width) : $newH;
$offsetx = 0;
$offsety = ($h - $cropedH) / 4;
} else {
//$newH = $height;
$cropedW = ($h > $height)? ($h * $width / $height) : $newW;
$cropedH = $h;
$offsetx = ($w - $cropedW) /2;
$offsety = 0;
}
$newIm = imagecreatetruecolor($width,$height);//$newW, $newH);
imagealphablending($newIm, false);
$colorTransparent = imagecolorallocatealpha($newIm, 255, 255, 255, 127);
imagefill($newIm, 0, 0, $colorTransparent);
imagesavealpha($newIm, true);
imagecopyresampled($newIm, $this->im, (($width-$newW)/2), (($height-$newH)/2), $offsetx, $offsety, $newW, $newH, $cropedW, $cropedH);
imagedestroy($this->im);
$this->im = $newIm;
-
Look at resizeTo function, then you will know which code to replace.
-
i still don't get it
-
i still don't get it
On my imageresizer.php it was lines 70 to 91.
Just a question. This fixed the thumbnail for ad listings which is big improvement! Thank you!
The other two image sizes still have the white border around them. Is this supposed to do anything with those images?
-
Hi skr678
This is full resizeTo code.
$fill is to remove whitespace.
$upscale is to allow to resize if image source is smaller.
But I don't think you want to use this whole code. Just cut the code that you don't want to use.
public function resizeTo($width, $height, $upscale = true, $fill = true) {
if (osc_use_imagick()) {
if ($fill) {
$geometry = $this->im->getImageGeometry();
$w = $geometry['width'];
$h = $geometry['height'];
if($upscale or (($w > $width) and ($h > $height))) {
if (($w / $width) < ($h / $height)) {
$this->im->cropImage($w, floor($height * $w / $width), 0, (($h - ($height * $w / $width)) / 4));
} else {
$this->im->cropImage(ceil($width * $h / $height), $h, (($w - ($width * $h / $height)) / 2), 0);
}
$this->im->ThumbnailImage($width, $height, true);
} else {
$newW = ($w > $width) ? $width : $w;
$newH = ($h > $height) ? $height : $h;
if (($w / $width) < ($h / $height)) {
$cropedW = $w;
$cropedH = ($w > $width) ? ceil($w * $height / $width) : $newH;
} else {
$cropedH = $h;
$cropedW = ($h > $height) ? ceil($h * $width / $height) : $newW;
}
$offsetx = ($w - $cropedW) / 2;
$offsety = ($h - $cropedH) / 4;
$this->im->cropImage($cropedW, $cropedH, $offsetx, $offsety);
$bg = new Imagick();
$bg->newImage($width, $height, 'white');
$x = ceil($width - $newW) / 2;
$y = ceil($height - $newH) / 2;
$bg->compositeImage($this->im, imagick::COMPOSITE_OVER, $x, $y);
$this->im = $bg;
}
} else {
$bg = new Imagick();
$bg->newImage($width, $height, 'white');
$geometry = $this->im->getImageGeometry();
if ($upscale or ($geometry['width'] > $width) or ($geometry['height'] > $height)) {
$this->im->thumbnailImage($width, $height, true);
$geometry = $this->im->getImageGeometry();
}
$x = ceil($width - $geometry['width']) / 2;
$y = ceil($height - $geometry['height']) / 2;
$bg->compositeImage($this->im, imagick::COMPOSITE_OVER, $x, $y);
$this->im = $bg;
}
} else {
$w = imagesx($this->im);
$h = imagesy($this->im);
if ($fill) {
if($upscale) {
$newW = $width;
$newH = $height;
} else {
$newW = ($w > $width) ? $width : $w;
$newH = ($h > $height) ? $height : $h;
}
if (($w / $h) < ($width / $height)) {
$cropedW = $w;
if($upscale){
$cropedH = ceil($w * $height / $width);
} else {
$cropedH = ($w > $width) ? ceil($w * $height / $width) : $newH;
}
$offsetx = 0;
$offsety = ($h - $cropedH) / 4;
} else {
$cropedH = $h;
if($upscale){
$cropedW = ceil($h * $width / $height);
} else {
$cropedW = ($h > $height) ? ceil($h * $width / $height) : $newW;
}
$offsetx = ($w - $cropedW) / 2;
$offsety = 0;
}
} else {
if(($w/$h)>=($width/$height)) {
if($upscale){ $newW = $width; } else { $newW = ($w > $width)? $width : $w; };
$newH = ceil($h * ($newW / $w));
} else {
if($upscale) { $newH = $height; } else { $newH = ($h > $height)? $height : $h; };
$newW = ceil($w * ($newH / $h));
}
$cropedW = $w;
$cropedH = $h;
$offsetx = 0;
$offsety = 0;
}
$newIm = imagecreatetruecolor($width, $height);
imagealphablending($newIm, false);
$colorTransparent = imagecolorallocatealpha($newIm, 255, 255, 255, 127);
imagefill($newIm, 0, 0, $colorTransparent);
imagesavealpha($newIm, true);
imagecopyresampled($newIm, $this->im, floor(($width - $newW) / 2), floor(($height - $newH) / 2), $offsetx, $offsety, $newW, $newH, $cropedW, $cropedH);
imagedestroy($this->im);
$this->im = $newIm;
}
return $this;
}
-
ok but where is imageresizer.php i cannot find it
-
ok but where is imageresizer.php i cannot find it
\oc-includes\osclass\classes
If you have osclass on your computer, you can just browse to it and do a search of osclass directory. Helps to find files quickly for me.
-
To clarify, the part that is in the OP is just to correct the thumbnail white space?
And the other parts of below allows resizing of other image sizes?
Thank you again. Really like the way the thumbnail looks with this mod.
Hi skr678
This is full resizeTo code.
$fill is to remove whitespace.
$upscale is to allow to resize if image source is smaller.
But I don't think you want to use this whole code. Just cut the code that you don't want to use.
public function resizeTo($width, $height, $upscale = true, $fill = true) {
if (osc_use_imagick()) {
if ($fill) {
$geometry = $this->im->getImageGeometry();
$w = $geometry['width'];
$h = $geometry['height'];
if($upscale or (($w > $width) and ($h > $height))) {
if (($w / $width) < ($h / $height)) {
$this->im->cropImage($w, floor($height * $w / $width), 0, (($h - ($height * $w / $width)) / 4));
} else {
$this->im->cropImage(ceil($width * $h / $height), $h, (($w - ($width * $h / $height)) / 2), 0);
}
$this->im->ThumbnailImage($width, $height, true);
} else {
$newW = ($w > $width) ? $width : $w;
$newH = ($h > $height) ? $height : $h;
if (($w / $width) < ($h / $height)) {
$cropedW = $w;
$cropedH = ($w > $width) ? ceil($w * $height / $width) : $newH;
} else {
$cropedH = $h;
$cropedW = ($h > $height) ? ceil($h * $width / $height) : $newW;
}
$offsetx = ($w - $cropedW) / 2;
$offsety = ($h - $cropedH) / 4;
$this->im->cropImage($cropedW, $cropedH, $offsetx, $offsety);
$bg = new Imagick();
$bg->newImage($width, $height, 'white');
$x = ceil($width - $newW) / 2;
$y = ceil($height - $newH) / 2;
$bg->compositeImage($this->im, imagick::COMPOSITE_OVER, $x, $y);
$this->im = $bg;
}
} else {
$bg = new Imagick();
$bg->newImage($width, $height, 'white');
$geometry = $this->im->getImageGeometry();
if ($upscale or ($geometry['width'] > $width) or ($geometry['height'] > $height)) {
$this->im->thumbnailImage($width, $height, true);
$geometry = $this->im->getImageGeometry();
}
$x = ceil($width - $geometry['width']) / 2;
$y = ceil($height - $geometry['height']) / 2;
$bg->compositeImage($this->im, imagick::COMPOSITE_OVER, $x, $y);
$this->im = $bg;
}
} else {
$w = imagesx($this->im);
$h = imagesy($this->im);
if ($fill) {
if($upscale) {
$newW = $width;
$newH = $height;
} else {
$newW = ($w > $width) ? $width : $w;
$newH = ($h > $height) ? $height : $h;
}
if (($w / $h) < ($width / $height)) {
$cropedW = $w;
if($upscale){
$cropedH = ceil($w * $height / $width);
} else {
$cropedH = ($w > $width) ? ceil($w * $height / $width) : $newH;
}
$offsetx = 0;
$offsety = ($h - $cropedH) / 4;
} else {
$cropedH = $h;
if($upscale){
$cropedW = ceil($h * $width / $height);
} else {
$cropedW = ($h > $height) ? ceil($h * $width / $height) : $newW;
}
$offsetx = ($w - $cropedW) / 2;
$offsety = 0;
}
} else {
if(($w/$h)>=($width/$height)) {
if($upscale){ $newW = $width; } else { $newW = ($w > $width)? $width : $w; };
$newH = ceil($h * ($newW / $w));
} else {
if($upscale) { $newH = $height; } else { $newH = ($h > $height)? $height : $h; };
$newW = ceil($w * ($newH / $h));
}
$cropedW = $w;
$cropedH = $h;
$offsetx = 0;
$offsety = 0;
}
$newIm = imagecreatetruecolor($width, $height);
imagealphablending($newIm, false);
$colorTransparent = imagecolorallocatealpha($newIm, 255, 255, 255, 127);
imagefill($newIm, 0, 0, $colorTransparent);
imagesavealpha($newIm, true);
imagecopyresampled($newIm, $this->im, floor(($width - $newW) / 2), floor(($height - $newH) / 2), $offsetx, $offsety, $newW, $newH, $cropedW, $cropedH);
imagedestroy($this->im);
$this->im = $newIm;
}
return $this;
}
-
Thanks for the code. Works fine in firefox,and other browsers, but in IE does not work. Can anyone fix it?
PS: I hate IE, it's never compactivel in anything :o
-
Thanks for the code. Works fine in firefox,and other browsers, but in IE does not work. Can anyone fix it?
PS: I hate IE, it's never compactivel in anything :o
it is about your theme css.
-
Hello byteGator, I forgot to edit my post. It was the internet history, after cleaned temporary files, internet explorer already recognized the dimensions. It works very well. Thanks for sharing this wonderful feature!
greetings
-
Please, tell me how to apply this solution only for thumbs - not for previews, and not for normal photos.
-
Hi byteGator,
I was also using this mod for a long time (set it and forget to revert back, even forgot where read it and who posted it, too lazy I guess :D). Thing is it does crop full-size images, which is kind of bad. Explanation: for example, if you use 4:3 ratio, then 16:10, 3:2, 2:1 or 16:9 images and other non-ideal ones will loose considerable amount of information. It is a good thing for thumbs and preview, but not so good for full-size images. For those who do not wish to crop images and loose image information, forced aspect ratio with added white or black color is still the best way.
Regards
dev101
-
It is a good thing for thumbs and preview, but not so good for full-size images.
Yes, exactly!
So I beg you, if anyone knows, please tell how to apply this solution only for thumbs.
-
Hi....
To use it for thumbnail and normal with different crop you can edit your ItemAction
this is my code, but maybe it already has to much modification:
public function uploadItemResources($aResources,$itemId)
{
if($aResources != '') {
$itemResourceManager = ItemResource::newInstance();
$folder = osc_images_path().floor($itemId/1000000)."/".sprintf("%02d", floor(($itemId%1000000)/10000))."/".sprintf("%02d", floor(($itemId%10000)/100))."/";
$numImagesItems = osc_max_images_per_item();
$numImages = $itemResourceManager->countResources($itemId);
foreach ($aResources['error'] as $key => $error) {
if($numImagesItems==0 || ($numImagesItems>0 && $numImages<$numImagesItems)) {
if ($error == UPLOAD_ERR_OK) {
$tmpName = $aResources['tmp_name'][$key];
$imgres = ImageResizer::fromFile($tmpName);
//$extension = osc_apply_filter('upload_image_extension', $imgres->getExt());
//$mime = osc_apply_filter('upload_image_mime', $imgres->getMime());
$extension ='jpg';
$mime = 'image/jpeg';
// Create normal size
$normal_path = $path = $tmpName."_normal";
$size = explode('x', osc_normal_dimensions());
$img = ImageResizer::fromFile($tmpName)->autoRotate()->resizeTo($size[0], $size[1], false);
if( osc_is_watermark_text() ) {
$img->doWatermarkText(osc_watermark_text(), osc_watermark_text_color());
} elseif ( osc_is_watermark_image() ){
$img->doWatermarkImage();
}
$img->saveToFile($path, $extension);
// Create preview
$path = $tmpName."_preview";
$size = explode('x', osc_preview_dimensions());
ImageResizer::fromFile($tmpName)->autoRotate()->resizeTo($size[0], $size[1], true)->saveToFile($path, $extension);
// Create thumbnail
$path = $tmpName."_thumbnail";
$size = explode('x', osc_thumbnail_dimensions());
ImageResizer::fromFile($tmpName)->autoRotate()->resizeTo($size[0], $size[1], true )->saveToFile($path, $extension);
-
Thank you very much, byteGator!
I just changed part of the osclass code
ImageResizer::fromFile($tmpName)->resizeTo($size[0], $size[1])->saveToFile($path);
on the part of your code, here it is:
ImageResizer::fromFile($tmpName)->resizeTo($size[0], $size[1], true )->saveToFile($path, $extension);
And now everything was excellent! Thumbs without white space, even with portrait images!
Many thanks!
-
I tryed but nothing happend only errors
I am trying to make those two mods
1. All thumbanils that are in Gallery and List mode - to be with fixed width/height, but one size for Gallery and other for List mode
2. All Small preview thumnails that are on a side of the main preview of item.php - to be with square size
Could some one tell what exactly I have to do.
10x
-
Here is my test, how this mode crop the images:
1. When is uploaded a Landscape image is everything ok into grid thumbnail, and preview item.php
but the main problem is in Portrait images
2. When is uploaded Portrait image, here is what happend:
2.1. Into the grid thumbnail the image is not centeret by height, it's croped from top 80px, croped from bottom 220px, left and right are ok the are on 0px
Question for this 2.1.: How to center the image verticaly for Portrait images, so the thumbnail to show absolut center of image
see attached image named: 1st-portrait-2nd-landscape-grid-thumnbails.png
2.2. Into the preview mode (item.php) the Portrait image is the same croped just as it is in 2.1. (above)
Question for this 2.2.: Hoe to show all of the Portrait image without any cropes, just full portrait size
see attached image named: preview-width-small-thumbnails.png
3. I think that is better the watermark to be added after all images are resized to each one, not only the first one and than to be rsized and to losing quality of the watermark, and to not be visible as is into this case of mod
Please also see the image: portrait-image-croped-by-preview-frame-as-a-landscape.png
This image shows how 600x800px Portrait image is croped, and how many data is lost, should be nice to let the portrait image to be all visible without crops into preview item.php
-
Hi ivv
2.1. To change offset, change this
$offsetx = ($w - $cropedW) / 2;
$offsety = ($h - $cropedH) / 4;
to
$offsetx = ($w - $cropedW) / 2;
$offsety = ($h - $cropedH) / 2;
2.2. To crop only thumbnail, change item action. See previous post.
3.1 Yes, watermark is added after crop and resize. It ALREADY work this way.
Regards
B
-
I changed the code from 2.11
Changed ItemAction but still portrait images are acroped as a landscape into preview item.php - hereis the image
I tryed both with on/off of
Force image aspect. No white background will be added to keep the size. - from admin
No luck,
-
All croped image will have standard height / width. So it cannot preserve your mode (portrait / landscape).
FOr me, I choose to use square thumbnail and preview.
-
Also I saw potential problem:
You post this:
2.1. To change offset, change this
Code: [Select]
$offsetx = ($w - $cropedW) / 2;
$offsety = ($h - $cropedH) / 4;
to
Code: [Select]
$offsetx = ($w - $cropedW) / 2;
$offsety = ($h - $cropedH) / 2;
But there is no change after I made this msetup at all,
BUT
if I change the code few rows below:
from:
}
$offsetx = 0;
$offsety = ($h - $cropedH) / 4;
} else {
$cropedH = $h;
if($upscale){
$cropedW = ceil($h * $width / $height);
} else {
$cropedW = ($h > $height) ? ceil($h * $width / $height) : $newW;
}
$offsetx = ($w - $cropedW) / 2;
$offsety = 0;
}
to:
}
$offsetx = 0;
$offsety = ($h - $cropedH) / 2;
} else {
$cropedH = $h;
if($upscale){
$cropedW = ceil($h * $width / $height);
} else {
$cropedW = ($h > $height) ? ceil($h * $width / $height) : $newW;
}
$offsetx = ($w - $cropedW) / 2;
$offsety = 0;
}
than both thumbnail and preview images are verticaly middle, is it a bug?
-
you do right things. It is not a bug.
I just want to tell you that for center you have to use offset /2
if you want to 25% offset at top and 75% offset at bottom, use offset /4.
-
And what to use for 0% offset :)
I see what you mean, but the cript should offset only the thumbnails and leave the preview untouched :)
-
Hi ivv
...
3.1 Yes, watermark is added after crop and resize. It ALREADY work this way.
Regards
B
If it's working like this why, there is no watermarks?
10x
-
1. No watermark at thumbnail and preview.
2. As I said before, if you want to change how osclass work on preview, you have to change ItemAction.php
I think all is clear. Please try your self.
-
Yes I know that, but I'm not a programmer, so I am on my own alone.
Just wanted to tell that there is no sence the portrait image in preview item.php to be as alandscape mode.
10x for the help
Cheers
-
Yes I know that, but I'm not a programmer, so I am on my own alone.
Just wanted to tell that there is no sence the portrait image in preview item.php to be as alandscape mode.
10x for the help
Cheers
Yes, i suggest you make it square. I use 200 x 200 pixel for thumbnail. Take a look at my site. :)
BTW, what is your site address?
Regards
-
Hi byteGator,
Any solution for this problem?
http://forums.osclass.org/general-help/increase-the-size-of-the-image/ (http://forums.osclass.org/general-help/increase-the-size-of-the-image/)
-
Hello everyone
Help me, I'm new and I do not understand a lot of the program, I do not like the pictures with different sizes and with white borders, I saw that you have solved the problem.
I have the theme Modern Plus 1.0 and would like to make changes .... but I'm afraid to combine trouble.
Do you have a complete file to replace my so that I do not break anything?
Sorry for writing but I'm using traslator
Aurora
-
:'( :'( :'( :'( :'( :'( :'(
-
Hello.
Even if you do not remove the spaces ..... at least reduce them
-
I made a simple request, but it's possible that in this forum NOT NO ONE HELPS YOU ??
I just have to recognize that Cartagena68 was the only one who helped me !!!
Or just because I do not speak and write in your own language and I have to help with a translator ???
-
These forums are FULL of replies and help.
If you get no reply could mean 2 things: (a) the answer is already posted in the forums and you have to search or (b) nobody knows the answer.
-
These forums are FULL of replies and help.
If you get no reply could mean 2 things: (a) the answer is already posted in the forums and you have to search or (b) nobody knows the answer.
Yes, that will be true in the forum you can find what you seek, but it is true that being a new and more do not speak your language, I have my problems, thank goodness that Cartagena has been and is still very useful help, I can not say how the other.
-
It will remove whitespace and crop 1/2 on width or 1/4 top & 3/4 bottom on height.
In ImageResizer.php use this calculation.
$w = imagesx($this->im);
$h = imagesy($this->im);
$newW = ($w > $width)? $width : $w;
$newH = ($h > $height)? $height : $h;
if(($w/$h)<($width/$height)) {
//$newW = $width;
$cropedW = $w;
$cropedH = ($w > $width)? ($w * $height / $width) : $newH;
$offsetx = 0;
$offsety = ($h - $cropedH) / 4;
} else {
//$newH = $height;
$cropedW = ($h > $height)? ($h * $width / $height) : $newW;
$cropedH = $h;
$offsetx = ($w - $cropedW) /2;
$offsety = 0;
}
$newIm = imagecreatetruecolor($width,$height);//$newW, $newH);
imagealphablending($newIm, false);
$colorTransparent = imagecolorallocatealpha($newIm, 255, 255, 255, 127);
imagefill($newIm, 0, 0, $colorTransparent);
imagesavealpha($newIm, true);
imagecopyresampled($newIm, $this->im, (($width-$newW)/2), (($height-$newH)/2), $offsetx, $offsety, $newW, $newH, $cropedW, $cropedH);
imagedestroy($this->im);
$this->im = $newIm;
In ItemActions.php
Change
ImageResizer::fromFile($normal_path)->resizeTo($size[0], $size[1])->saveToFile($path);
TO
ImageResizer::fromFile($tmpName)->resizeTo($size[0], $size[1])->saveToFile($path);
twice.
And you can adjust your image/thumbnail size in oc-admin page.
Hello. This fix works with bender theme? Thanks
-
It is working with the latest version osclass?
-
Hello,
Does anyone know a solution to this issue on osclass 3.8.0?
thanks