Custom field search

[marius-ciclistu]

This will slow down your db queries because it searches directly into your table.  The osclass search is made not into the table that helds the items' title and description, but in the full index generated when the item was saved. You can read more about this online.

[marius-ciclistu]

In order to not loose the advantages offered by full index, you need to modify the core in order to generate full index for metas column and then modify the search to search also into that full index.

[Sophia_OS]

This will slow down your db queries because it searches directly into your table.  The osclass search is made not into the table that helds the items' title and description, but in the full index generated when the item was saved. You can read more about this online.

in this function, first part keyword_wildcard is also slow down db? or just second part customfield search in function slow down db?


can you please help me to fix it to search by location too?

[marius-ciclistu]

The wildcard is used on full index, it returns more results, so yes, but not so much as querying directly into the db tabes.

[Sophia_OS]

The wildcard is used on full index, it returns more results, so yes, but not so much as querying directly into the db tabes.

can you please help me to fix this function to search by location too?
why with this function it doesn't search by location?

[marius-ciclistu]

I'm on my phone now. Try to var_dump();die; on a test server the whole query to see it.

[Sophia_OS]

I'm on my phone now. Try to var_dump();die; on a test server the whole query to see it.

you know what? with this function it searches the custom-fields very good. the only problem is that on search.php (modern theme) when you select a location, it doesn't find by that location.
i'm waiting for you to take a look at this function and test it with a computer. hopefully you fix that. thanks.

[marius-ciclistu]

function cust_search_keyword_wildcard_with_customfield($params) {

    if ($params['sPattern']) {
        $mSearch =  Search::newInstance();
        $query_elements = (array) json_decode($mSearch->toJson());
        $pattern = $query_elements['sPattern'];


        $query_elements['sPattern'] = str_replace(' ', '* ', $pattern) . '*';

        $mSearch->setJsonAlert($query_elements);

        // Search by customfield too
        $mSearch->addJoinTable(count($query_elements['tables_join']), DB_TABLE_PREFIX."t_item_meta u", "pk_i_id = u.fk_i_item_id", 'LEFT');

        $aPattern = explode(' ', $pattern);
        $customfieldCond = '';

        foreach ($aPattern as $word) {
            if ($word) $customfieldCond .= sprintf(" || u.s_value like '%%%s%%'", $word);
        }

        $mSearch->addConditions("1 = 1 " . $customfieldCond);
        $mSearch->addGroupBy(DB_TABLE_PREFIX.'t_item.pk_i_id');
    }
}

osc_add_hook('search_conditions', 'cust_search_keyword_wildcard_with_customfield', 1);

[/code]

I gues you need to add conditions for region and maybe category   keys from the $params parameter. I can't test it locally. Maybe Teseo can have a look.

Also, does your filter work? Is your search returning only results from a selected category?

[Sophia_OS]

Alright, we wait for teseo to take a look at this function.
Search for custom fields is working great. The only problem is that dosnt work by selecting location in search.php (modern theme)

[marius-ciclistu]

Swich to bender(put that function into functions.php) and test. If it doesn't work it's not theme related.

[Sophia_OS]

Swich to bender(put that function into functions.php) and test. If it doesn't work it's not theme related.

no its not theme related

[marius-ciclistu]

I think this is the problem.

 foreach ($aPattern as $word) {
            if ($word) $customfieldCond .= sprintf(" || u.s_value like '%%%s%%'", $word);
        }

That || ( or ) makes results show even if they don't belong to a region.

Is that the behaviour?

[WEBmods]

I think this is the problem.

 foreach ($aPattern as $word) {
            if ($word) $customfieldCond .= sprintf(" || u.s_value like '%%%s%%'", $word);
        }

That || ( or ) makes results show even if they don't belong to a region.

Is that the behaviour?

Hello,

I suggest you put OR queries between braces. I've had a similar problem on one plugin I worked on, if I would do this like I did on the plugin it would look like this:

Code: [Select]

<?php
$customfieldCond = '(';

foreach ($aPattern as $word) {
        if ($word) $customfieldCond .= sprintf(" || u.s_value like '%%%s%%'", $word);
}

$customfieldCond .= ')';
?>

Regards.

[Sophia_OS]

I think this is the problem.

 foreach ($aPattern as $word) {
            if ($word) $customfieldCond .= sprintf(" || u.s_value like '%%%s%%'", $word);
        }

That || ( or ) makes results show even if they don't belong to a region.

Is that the behaviour?

but it doesn't work if i remove ||

[Sophia_OS]

I think this is the problem.

 foreach ($aPattern as $word) {
            if ($word) $customfieldCond .= sprintf(" || u.s_value like '%%%s%%'", $word);
        }

That || ( or ) makes results show even if they don't belong to a region.

Is that the behaviour?

Hello,

I suggest you put OR queries between braces. I've had a similar problem on one plugin I worked on, if I would do this like I did on the plugin it would look like this:

Code: [Select]

<?php
$customfieldCond = '(';

foreach ($aPattern as $word) {
        if ($word) $customfieldCond .= sprintf(" || u.s_value like '%%%s%%'", $word);
}

$customfieldCond .= ')';
?>

Regards.

@patrickFromCroatia
it didn't work, it even didn't find custumfields