"Check with seller and 0"

[sundance]

Until 2.3 becomes stable (I know it is fixed there) can someone tell me how to fix the issue with "check with seller" and 0? I can make it do one or the other, but the code is glitching to where even though it says to, it won't do both.
right now mine says:
 function osc_format_price($price) {
        if ($price == 0) return __('Free') ;
        if ($price == null) return __('Check with seller') ;
        //if ($price == 0) return __('Free') ;
        $currencyFormat =  osc_locale_currency_format();

It still says only "free" because the site adds a 0 even if you leave it blank. Does anyone know what they did to fix it so I could fix it for my 2.2.3?

[trains58554]

Hi

I have found the commit of the changes they did to fix this problem. I tried the changes on my 2.2.3 but it did no change I think there must be anther file that needs changing. Anyways here is a link to the changes.

https://github.com/osclass/OSClass/commit/31d66f8bb3f65b6dae4a4ee65e8620a9bc4ffdd6

Jay

[Evelyne]

It still says only "free" because the site adds a 0 even if you leave it blank. Does anyone know what they did to fix it so I could fix it for my 2.2.3?

I've been having to manually correct prices because it's changing to "0" prices left blank, and it's publishing them as "Free", which causes A LOT of confusion!!!

How can I stop this "null" turning into "0"?

I checked Jay's link, but both lines highlighted are as he mentioned in his post, and I'm still getting the problem:

oc-includes/osclass/installer/struct.sql:
207     i_price BIGINT(20) NULL,

/oc-includes/osclass/ItemActions.php
1074            $aItem['price']         = (Params::getParam('price') != '') ? Params::getParam('price') : null;

Any ideas on  how to fix the automatic conversion of NULL to "0" when posting a new ad?

[hallartistry]

I'm getting the same problem. It used to say Check with Seller, but now it says Free when the price is 0? Not sure what happened!

[hallartistry]

Oh, nevermind lol  I just noticed it is supposed to say Free when someone puts 0 in the price, and it does say check with seller when there is nothing in the price field. All clear now! I just need to specify that in the ad post so people know that if they don't want it to say free they need to just not put anything in the price box.

[guitarrista]

Until 2.3 becomes stable (I know it is fixed there) can someone tell me how to fix the issue with "check with seller" and 0? I can make it do one or the other, but the code is glitching to where even though it says to, it won't do both.
right now mine says:
 function osc_format_price($price) {
        if ($price == 0) return __('Free') ;
        if ($price == null) return __('Check with seller') ;
        //if ($price == 0) return __('Free') ;
        $currencyFormat =  osc_locale_currency_format();

It still says only "free" because the site adds a 0 even if you leave it blank. Does anyone know what they did to fix it so I could fix it for my 2.2.3?

Where to find this code? Pls. help.