Image rotation issue when using ImageMagick

[jazepsmalta]

Image rotation issue when using ImageMagick

I am using ImageMagick library on my website,
Unfortunately after image upload from mobile phones it rotates some images.


Is there a solution to this problem?

[dev101]

Please, upload some ORIGINAL sample images here or on some server (archive them into .zip if you wish, just don't process them in any photo editor or through other app).

[jazepsmalta]

Please, upload some ORIGINAL sample images here or on some server (archive them into .zip if you wish, just don't process them in any photo editor or through other app).

I uploaded original image in zip format on google drive,

Thumbnail images - displayed normally, without turning
Normal size images - turns on 90 degrees.

https://drive.google.com/open?id=1J1JVMB1K7eRwW0C2XTqIrp7-f14KjD9g

[jazepsmalta]

really, nobody faced such problem?

[dev101]

This image is in Apple HEIC format, I am not sure what is happening during upload/conversion on your server. I assume phone recognizes that there is no support for it, and then serves JPEG equivalent. Because, as it is now, Osclass does not support anything beyond GIF, PNG and common JPEG. Will investigate this in my spare time.

edit: as expected, this is invalid extension, and it cannot be examined and work upon directly now, because it is not supported.

Code: [Select]

IMG_0396.HEIC has an invalid extension. Valid extension(s): png, gif, jpg, jpeg.
What happens during image conversion and serving in the phone (at least, this is my best guess), is beyond my research ability right now.

[jazepsmalta]

This image is in Apple HEIC format, I am not sure what is happening during upload/conversion on your server. I assume phone recognizes that there is no support for it, and then serves JPEG equivalent. Because, as it is now, Osclass does not support anything beyond GIF, PNG and common JPEG. Will investigate this in my spare time.

edit: as expected, this is invalid extension, and it cannot be examined and work upon directly now, because it is not supported.

Code: [Select]

IMG_0396.HEIC has an invalid extension. Valid extension(s): png, gif, jpg, jpeg.
What happens during image conversion and serving in the phone (at least, this is my best guess), is beyond my research ability right now.

dev101  this happens only when i turn on ImageMagick. If i use GD library, there is no such problem. but the quality of uploaded photos is very bad when using this library "GD library". In ImageMagick uploaded photos are little better.

Is it possible to change the quality of uploaded photos?

[dev101]

Again, this needs to be examined in detail, the whole chain of events. Yes, we can increase quality, but default one should be fine, unless something very wrong is going on. It's a new format, it is not supported out of the box, and I have few ideas/theories of what is happening, none proven for a fact yet.

[jazepsmalta]

Again, this needs to be examined in detail, the whole chain of events. Yes, we can increase quality, but default one should be fine, unless something very wrong is going on. It's a new format, it is not supported out of the box, and I have few ideas/theories of what is happening, none proven for a fact yet.

I meant to improve the quality of uploaded photos for all formats, not only for Apple HEIC.  If we upload photos in JPG, then after processing they are pretty bad quality, I would like to keep the best possible. Thanks

[dev101]

I have investigated this issue, and on my server (PHP 7.2.16 or PHP 7.3.3 / imagick 3.4.3 / ImageMagick 6.9.4-10 Q16 x86_64) running more or less stock 3.80 with Bender theme (irrelevant), I had only issues with portrait images posted using ImageMagick. As in your heic example, it was captured with iPhone 7, so here is my test:

iPhone 7 / 7 Plus / plus few Android Phones
(Safari browser with iOS devices)

GD Library   |   with PreResize plugin  |   without PreResize plugin
landscape    |   no issue                       |   no issue
portrait         |   no issue                       |   no issue

IM Library   |   with PreResize plugin  |   without PreResize plugin
landscape    |   no issue                       |   no issue
portrait         |   no issue                       |   YES - ISSUE!

In ALL 4 test cases I have NOT experienced any quality issues you've encountered and described. Problem with autorotation is that it seems both ajax and later processing stages are rotating the image twice, which creates the problem. I am not sure, but that seems to be the most logical scenario according to my tests. Also, not sure how this slipped through before, maybe things changed... I need more samples and tests for this to draw a conclusion. In any case, core code is correct, nothing wrong with it, except this rotation issue.

I already have a fix for rotation problem, will post it later. Initial tests show that it is working.

Test examples from above compiled table are available (for a limited time) on my demo website (url under my profile), just so you can see that I'm telling the truth. You can see that beside rotation issue, quality does not suffer and I don't see any reason to change anything in that regard.

In case if you use preResize plugin by teseo, issue is not present in all cases (GD/IM).

My theory is that your theme uses very small thumbnails instead of larger images, and maybe that creates a problem for you.

Regards
dev101

[jazepsmalta]

I have investigated this issue, and on my server (PHP 7.2.16 or PHP 7.3.3 / imagick 3.4.3 / ImageMagick 6.9.4-10 Q16 x86_64) running more or less stock 3.80 with Bender theme (irrelevant), I had only issues with portrait images posted using ImageMagick. As in your heic example, it was captured with iPhone 7, so here is my test:

iPhone 7 / 7 Plus / plus few Android Phones
(Safari browser with iOS devices)

GD Library   |   with PreResize plugin  |   without PreResize plugin
landscape    |   no issue                       |   no issue
portrait         |   no issue                       |   no issue

IM Library   |   with PreResize plugin  |   without PreResize plugin
landscape    |   no issue                       |   no issue
portrait         |   no issue                       |   YES - ISSUE!

In ALL 4 test cases I have NOT experienced any quality issues you've encountered and described. Problem with autorotation is that it seems both ajax and later processing stages are rotating the image twice, which creates the problem. I am not sure, but that seems to be the most logical scenario according to my tests. Also, not sure how this slipped through before, maybe things changed... I need more samples and tests for this to draw a conclusion. In any case, core code is correct, nothing wrong with it, except this rotation issue.

I already have a fix for rotation problem, will post it later. Initial tests show that it is working.

Test examples from above compiled table are available (for a limited time) on my demo website (url under my profile), just so you can see that I'm telling the truth. You can see that beside rotation issue, quality does not suffer and I don't see any reason to change anything in that regard.

In case if you use preResize plugin by teseo, issue is not present in all cases (GD/IM).

My theory is that your theme uses very small thumbnails instead of larger images, and maybe that creates a problem for you.

Regards
dev101

Hello, dev101

Did you find any solution for issue ?

[dev101]

Try this:
https://github.com/osclass/Osclass/pull/2302

[jazepsmalta]

Try this:
https://github.com/osclass/Osclass/pull/2302

dev101,

Thanks a lot, everything works fine

[jazepsmalta]

dev101,

I have another problem with photos, this question has already been asked many years ago, but is there any solution of this issue in osclass v. 3.8.0?
 
Here is a link to old topic.

https://forums.osclass.org/development/much-better-image-resize-smart-offset-no-white-space/