Osclass Extreme Memory Usage with Multi-Country

[Aficionado]

@Aficionado
I have checked your file and found that there is more queries running for long time (8 or more seconds), there is probably relation to city table in all of them. It is very strange.

And that is related to memory problems  ?

[teseo]

Hi,

@frosticek, those are exponential numbers (9.7036361694336E-5), in fact they are very small values.

This is what bothers me:

Code: [Select]

1.6615619659424
**************************************************
SELECT pk_i_id, fk_i_region_id, s_name, fk_c_country_code, b_active, s_slug
FROM (oc_t_city)
ORDER BY s_name ASC
--------------------------------------------------
What module would need to retrieve absolutely all the cities in your database in alphabetical order?

@Aficionado, have you tried using another theme?

Regards

[Aficionado]

@Aficionado, have you tried using another theme?

Regards

Yes, Bender and Modern. Same problem. But OsclassWizards is based on Bender, so ... if Bender had this ....

I will spend this weekend to solve this, since i can't bear it anymore. If Osclass can't handle multi-countries then i will have to find something else for this case.

[frosticek]

@teseo
Ah yes I missed that.
I have same query on my theme, but with filter on region ID.

[teseo]

...

[teseo]

That query is produced by osc_get_cities() helper with no region parameter. Also, it might appear as City::newInstance()->listAll();

Now, in vanilla Bender is only used in user-profile.php, and even if the user still hasn't set any location it would retrieve only the cities of the 1st country in your database.

So, you must have something like that in a plugin or in some custom modification.

Regards

[Aficionado]

That query is produced by osc_get_cities() helper with no region parameter. Also, it might appear as City::newInstance()->listAll();

Now, in vanilla Bender is only used in user-profile.php, and even if the user still hasn't set any location it would retrieve only the cities of the 1st country in your database.

So, you must have something like that in a plugin or in some custom modification.

Regards

I have no modifications related to that. But i have some plugins from Osclass team, like rich edit etc etc. I will disable everything and test with stock Bender and come back to post.

But i do remember same problems with Modern theme, still i will try again.

[Aficionado]

ok. some update on this for anyone who cares to read.

For some reason Bender i was testing was Bender 2.01 and i installed Bender 3x. With Bender 3 i see no memory errors with 256 mb.

So, without being 100% sure, i think it is theme related. I will do some more testing with other themes and see how it goes.

Editing an ad WITHIN admin/Listings there is no error whatever. So one more reason to see if it is theme related.

[teseo]

***CORRECTED AGAIN***

It's a theme issue. Just seen a reference to Osclasswizards on your queries log.

Locate this in item-post:

Code: [Select]

ItemForm::city_select(osc_get_cities(),osc_user());
an replace with:

Code: [Select]

ItemForm::city_select(osc_get_cities(osc_user_region_id()), osc_user());
That seems to be working all right with no loading of all cities anymore.

Regards

[Aficionado]

@Teseo

Dude i don't know HOW TO THANK YOU !!

THANKS !!!

That did solve the problem and also some strange timeouts when editing.

I will copy your fix to their forum.

Again, a big Thanks.

[teseo]

...

[Aficionado]

@Teseo

Are the above fixes only for multi-countries ?

[SmaRTeY]

Nice find teseo!

One question looking at the whole thread here, were ALL cities (from all countries) being loaded using that initial code??


Regards,
Eric

[dev101]

I was completely absent from the forums past few days and I missed this exciting discussion.
Although teseo already did a great job, I would just add a different approach for solution:

Code: [Select]

ItemForm::city_select(osc_get_cities(osc_user_region_id()), osc_user());

ItemForm class is still being used (instead of UserForm in teseo's solution) which keeps things as it should.

Regards
dev101

[teseo]

Hi @dev101,

Yep, I was looking at the only use of osc_get_cities() -with no region parameter- in Bender vanilla, in user-profile.php and I used Userform:: inadvertedly, same result anyway.

Now I realize the solution you propose is what is recommended here:

https://doc.osclass.org/Changing_between_drop-down_and_autocomplete_for_locations

And seems good enough. If it's a non-logged user or a logged user with no location data in his/her profile yet, that would retrieve cities for the first country in the database.

My hack using that dummy array (1,2) intended to save time and skip population of a select that will be overriden later via Ajax call (once you expressly select a region), but seems you need something more there for the neutral option "Select a city" to be shown...

What is totally clear is that osc_get_cities() -with no region parameter- never should be used unless (as in the case on that user-profile.php) already a View variable "cities" has been created.

Thanks for your input, regards.