[ SOLVED ] One ad shows a double

[Abdurauf]

One ad shows a double
What problem?

[_CONEJO]

Hi, which version of OSClass are you using ?

[Abdurauf]

Hi, which version of OSClass are you using ?

Hi. Last version. OsClass 2.3.1

[bilekas]

You have not closed the php correctly for the if premium..

Close this if statement before the even is ++ ! This is what i would suspect!

[akapar]

I also have same issue. All ads on main page appear twice. I think this should be related to some issues with main.php. I would appreciate urgent help on this. Check 05suq.com to see the issue.

Regards, akapar...

[_CONEJO]

I could only see Arabic, but ... do you have any other language installed ? Even if it's disable , we're trying to reproduce this issue

[akapar]

website is only Arabic, i have both English and Arabic enabled at Admin panel. I tried also making admin panel only Arabic but it doesn't solve the issue. Attached is my main.php file, same as latest version except a small modification to hide sub-categories which was suggested by Juan Ramon at http://forums.osclass.org/index.php/topic,574.0.html

[Juan Ramón]

@akapar: If you give me access to your DB and FTP via PM I can try to figure out what's happening.

[arabasatis]

I have the same issue.

When I tried whats happening behind scenes I figured that :

in /oc-includes/osclass/model/Search.php, around line 660 , there is a query like that :

Code: [Select]

$this->sql = sprintf("SELECT  %st_item.*, %st_item_location.*, cd.s_name as s_category_name %s FROM %st_item, %st_item_location, %st_category, %st_category_description .....
which returns items as multiplied by language count:  eg. one description from english, one from german.

I will try to solve in time but just wanted give a hint.

[akapar]

Hi arabasatis,

I think you are on the right track. My website has category descriptions maintained both in English and Arabic. Please let us know if you find a solution for the issue.

Regards.

05suq.com

[Abdurauf]

osc_count_latest_items() value gives twice as much.
Cod

Site

[arabasatis]

Here is my solution:

in /oc-includes/osclass/model/Search.php, around line 660 (the line that I mentioned in my previous post)

change the query lline as below:

Code: [Select]

$this->sql = sprintf("SELECT  %st_item.*, %st_item_location.*, cd.s_name as s_category_name %s FROM %st_item, %st_item_location, %st_category, %st_category_description as cd WHERE %st_item_location.fk_i_item_id = %st_item.pk_i_id %s AND %st_item.fk_i_category_id = cd.fk_i_category_id and cd.fk_c_locale_code = '%s' ORDER BY %s %s LIMIT %d, %d", DB_TABLE_PREFIX, DB_TABLE_PREFIX, $extraFields,DB_TABLE_PREFIX, DB_TABLE_PREFIX, DB_TABLE_PREFIX ,DB_TABLE_PREFIX, DB_TABLE_PREFIX, DB_TABLE_PREFIX, $conditionsSQL, DB_TABLE_PREFIX, osc_language(), $this->order_column, $this->order_direction, $this->limit_init, $this->results_per_page);

here, we are just adding a "AND cd.fk_c_locale_code = '%s'" condition just before "ORDER BY" and we are giving osc_language() as sprintf format parameter.

[_CONEJO]

Try using this file instead of oc-includes/osclass/model/Search.php
Download from here --> https://raw.github.com/osclass/OSClass/develop/oc-includes/osclass/model/Search.php

[akapar]

Conejo, arabasatis,

Unfortunately both of the recommendations do not solve the issue, my website still shows double ads on main page.

[trains58554]

Hi akapar,

Are the ads that are showing more than once marked as premium?

Jay