Advertisement:

Author Topic: Gdpr compliance plugin  (Read 4782 times)

dev101

  • Osclass Hero
  • Hero Member
  • *
  • Posts: 2155
  • osclass.work
Re: Gdpr compliance plugin
« Reply #60 on: August 12, 2018, 03:12:55 pm »
Correct.

The fix is easy in case we don't need acceptance in this case (and we probably don't):



open .../gdpr_osclass/class/OsclassGdpr.php file and delete line #296 code (in version 1.2.1):

Code: [Select]
if(osc_is_current_page('login', 'recover_post')) { return true; }


In case the acceptance is required, checkbox form needs to be included, but the problem is there's a missing hook in that form, so themes will require update.

Regards
dev101
« Last Edit: August 12, 2018, 04:23:00 pm by dev101 »

Aficionado

  • Guest
Re: Gdpr compliance plugin
« Reply #61 on: August 12, 2018, 03:23:34 pm »
Correct.

The fix is easy in case we don't need acceptance in this case (and we probably don't):



open .../gdpr_osclass/class/OsclassGdpr.php file and delete line #298 code:

Code: [Select]
if(osc_is_current_page('login', 'recover_post')) { return true; }



dev101

Does the above mean we do not need/have GDPR in Login and Recover ?

If so, we do not i guess.

Thanks for the solution.

dev101

  • Osclass Hero
  • Hero Member
  • *
  • Posts: 2155
  • osclass.work
Re: Gdpr compliance plugin
« Reply #62 on: August 12, 2018, 03:26:15 pm »
I don't really know, but probably not.

I haven't seen anywhere this, because once user accepts the terms during registration, it is assumed he is already familiar with the conditions in login page.

Plugin already "doesn't work" in login form.

Aficionado

  • Guest
Re: Gdpr compliance plugin
« Reply #63 on: August 12, 2018, 04:12:10 pm »
Correct.

The fix is easy in case we don't need acceptance in this case (and we probably don't):



open .../gdpr_osclass/class/OsclassGdpr.php file and delete line #298 code:

Code: [Select]
if(osc_is_current_page('login', 'recover_post')) { return true; }


In case the acceptance is required, checkbox form needs to be included, but the problem is there's a missing hook in that form, so themes will require update.

Regards
dev101

It is line 296 in my version of GDPR plugin ??????

dev101

  • Osclass Hero
  • Hero Member
  • *
  • Posts: 2155
  • osclass.work
Re: Gdpr compliance plugin
« Reply #64 on: August 12, 2018, 04:24:07 pm »
Sorry, I have added 2 extra lines during testing, it is #296 in original plugin version 1.2.1, thanks!
I have edited my original post.

cartagena68

  • issues
  • Hero Member
  • *
  • Posts: 1198
Re: Gdpr compliance plugin
« Reply #65 on: August 12, 2018, 06:28:22 pm »
Quote
In case the acceptance is required, checkbox form needs to be included, but the problem is there's a missing hook in that form, so themes will require update.

Regards
dev101

Hi, if you use the latest version of the plugin ( Version:1.2.1 ) you just need to add this code
Code: [Select]
<?php osc_run_hook('gdpr'); ?>
to the page you need to add the checkbox, in this case the page user-recover.php and, of course, Update "I agree to terms" text in plugin settings
« Last Edit: August 12, 2018, 11:45:46 pm by cartagena68 »

fuligjimmy

  • Newbie
  • *
  • Posts: 9
  • All questions are hard if you don't kno the answer
Re: Gdpr compliance plugin
« Reply #66 on: August 12, 2018, 06:51:28 pm »

I've just come across a problem with the GDPR plugin.
When a user clicks on "Forgot Password" the option to click the acceptance of the terms and privacy policy wouldn't appear.
The user enters their email address to reset the password but when clicking the button an error message comes up. Basically the new password request is not functioning as there is no option to click to accept the above mentioned.


From what page is that ? Login ? Register ?

I don't see any GDPR in Login page ..... Can you explain better ?

Hi,
It's from the login page when a user forgets their login details and clicks on the link at the bottom.

fuligjimmy

  • Newbie
  • *
  • Posts: 9
  • All questions are hard if you don't kno the answer
Re: Gdpr compliance plugin
« Reply #67 on: August 12, 2018, 07:01:57 pm »
The solution works perfectly, thank you very much :-)

cartagena68

  • issues
  • Hero Member
  • *
  • Posts: 1198
Re: Gdpr compliance plugin
« Reply #68 on: August 12, 2018, 07:08:06 pm »
I think both are working, wich one you have used.

fuligjimmy

  • Newbie
  • *
  • Posts: 9
  • All questions are hard if you don't kno the answer
Re: Gdpr compliance plugin
« Reply #69 on: August 12, 2018, 10:25:00 pm »
I've used DEV101's solution to delete "if(osc_is_current_page('login', 'recover_post')) { return true; }".

dev101

  • Osclass Hero
  • Hero Member
  • *
  • Posts: 2155
  • osclass.work
Re: Gdpr compliance plugin
« Reply #70 on: August 14, 2018, 02:39:12 am »
Quote
In case the acceptance is required, checkbox form needs to be included, but the problem is there's a missing hook in that form, so themes will require update.

Regards
dev101

Hi, if you use the latest version of the plugin ( Version:1.2.1 ) you just need to add this code
Code: [Select]
<?php osc_run_hook('gdpr'); ?>
to the page you need to add the checkbox, in this case the page user-recover.php and, of course, Update "I agree to terms" text in plugin settings

Hi cartagena68,

yes, you are correct, of course; however, my focus was on a solution that does not require any theme modifications, at least from a functional PoV (css/html structure will probably be a problem as universal approach is not yet 100% possible).

I have proposed a new/missing hook here: https://github.com/osclass/theme-bender/pull/73

Regards
dev101

Aficionado

  • Guest
Re: Gdpr compliance plugin
« Reply #71 on: September 30, 2018, 12:23:38 pm »
It seems that ALERT subscriptions do not work when GDPR plugin is enabled.

Invalid Email error displayed. Can somebody else test and verify this in his site ?