[SOLVED] How remove "type="text/javascript"" from osc_enqueue_script function

[AdrianOlmedo]

I have this couple of lines of code in head.php:

Code: [Select]

osc_register_script('jquery-ui-min', osc_current_web_theme_js_url('jquery-ui.min.js'), array('jquery'));
osc_enqueue_script('jquery-ui-min');
that generate the following:

Code: [Select]

<script type="text/javascript" src="http://localhost/osclass/oc-content/themes/template/js/jquery.min.js"></script>
But the html5 validator marks error, saying that type="text/javascript" is obsolete and should not be placed

How remove type="text/javascript" ?

[dev101]

Hi, edit Scripts.php near the end:

https://github.com/osclass/Osclass/blob/master/oc-includes/osclass/classes/Scripts.php#L89

Regards

[dev101]

Btw. you shouldn't worry too much about W3C compliance, for several reasons. Those are just warnings, not errors. And, who knows, why you should remove compatibility with some older browsers/systems this way? It doesn't do any harm.

Regards

[AdrianOlmedo]

Hi, edit Scripts.php near the end:

https://github.com/osclass/Osclass/blob/master/oc-includes/osclass/classes/Scripts.php#L89

Regards

That is a direct solution, I asked if there was a way to do it from the theme (functions.php)

[dev101]

Only if you avoid using it (not recommended).

Regards

[WEBmods]

Hello,

I've seen code similar to this in Shopclass theme's functions.php. Might be a solution to your problem.

Code: [Select]

<?php
osc_remove_hook( 'header' , 'osc_load_scripts' );

function cust_load_scripts() {
    foreach ( Scripts::newInstance()->getScripts() as $script ) {
        echo '<script src="' . osc_apply_filter( 'theme_url' , $script ) . '"></script>' . PHP_EOL;
    }
}
osc_add_hook( 'header' , 'cust_load_scripts' );
?>

Regards.

[dev101]

You can invent your own functions or extend core for sure, but in this case it's simpler and much faster to modify a single core file, instead of every other theme or plugin. It's your choice, really. But, as I mentioned earlier, the goal is not very important. W3C and HTML5 is a "work in progress", which means unless you continuously check for compliance, at one point you might become incompatible again. Better invest your time & energy into more important issues, than simple html scheme rules IMHO.

Regards

[AdrianOlmedo]

Hello,

I've seen code similar to this in Shopclass theme's functions.php. Might be a solution to your problem.

Code: [Select]

<?php
osc_remove_hook( 'header' , 'osc_load_scripts' );

function cust_load_scripts() {
    foreach ( Scripts::newInstance()->getScripts() as $script ) {
        echo '<script src="' . osc_apply_filter( 'theme_url' , $script ) . '"></script>' . PHP_EOL;
    }
}
osc_add_hook( 'header' , 'cust_load_scripts' );
?>

Regards.

Perfect, it works. Thank you all