[BUG] Parameters

[frosticek]

On 3.7, when I use following URL:
http://my_site.com/index.php?page=item&action=send_friend&id=112&content_type=add_comment

Then parameter ID is taken as "112&content_type=add_comment" and not just "112"
Parameter CONTENT_TYPE is not possible to get.

So it is not possible to custom parameters in URLs.

On 3.6.3, everything works fine.

[SmaRTeY]

Hi Frosti,

you meant 3.6.1 or was there a 3.6.3 I missed?
(Nice catch b.t.w.)


Regards,
Eric

[dev101]

Hi Michael,

there was a necessary change in parameters to fix some old bugs, but it is possible this introduced the bug you've noticed.

Here's the issue:
https://github.com/osclass/Osclass/issues/2092

Regards

[frosticek]

For me it is pretty critical. In my themes I customize files with different parameters so it is not functional now...

[_CONEJO]

We can not reproduce this issue, could you tell us something more about your setup?

[developerchris]

parameter parsing is done in php. are you sure you are using the ampersand '&' and not '&' which is html encoded ampersand

[frosticek]

I am going to reinstall my dev installation, it behave little weird in last weeks and maybe upgrade did not helped.

[frosticek]

There could be 1 major bug with 3.7 upgrade.
It tells php 5.6 or higher is required, however I had osclass 3.6.3 with php 5.3 and it allowed me to upgrade into 3.7...

[frosticek]

@_CONEJO
fixed by changing name of parameter content_type.... using this name it stopped to work.

[dev101]

Requirement is only for new installations.

[_CONEJO]

There could be 1 major bug with 3.7 upgrade.
It tells php 5.6 or higher is required, however I had osclass 3.6.3 with php 5.3 and it allowed me to upgrade into 3.7...

As dev101 said, requirement is for new installation. It should work fine with PHP 5.3 (and even previous versions), but you should think and upgrade your PHP version. PHP 5.3 is "dead" since August 2014. https://en.wikipedia.org/wiki/PHP#Release_history  But we could not/should not support old versions of PHP, too many problems with compatibility.

The performance improvement from changing to PHP 7.0 (or higher) is huge

[_CONEJO]

Please try this fix : https://github.com/osclass/Osclass/commit/ecfe72932f2467097473f854a0812358ae21afc9#diff-d6335c50f2d0536514781dc51d34f72a

[dev101]

As it turned out, this issue is related (but different system and bug manifestation):
http://forums.osclass.org/3-7-x/search-not-work-after-update-3-6-to-3-7-help-please!!!/

[frosticek]

@_CONEJO
Sorry for delay, fix works.

[frosticek]

@_CONEJO
I found next bug here. Parameters are being messed somehow.
I.e. try this:
- use default bender theme
- go to search page
- enter min price, i.e. 22
- parameter 22 is assigned to sPattern instead of sMinPrice

URL is:
...index.php?page=search&sOrder=dt_pub_date&iOrderType=desc&sPattern=22

Instead of:
...index.php?page=search&sOrder=dt_pub_date&iOrderType=desc&sMinPrice=22